Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28019

Implement file management for HTML-related file areas

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1, 2.2, 2.3, 2.3.2, 2.4.3, 2.5
    • Fix Version/s: 2.6
    • Component/s: Files API, Repositories
    • Labels:
    • Testing Instructions:
      Hide

      Test required for two new plugins: tinymce_managefiles and repository_areafiles.

      Test 1. Basic editor

      1. Open any form with empty texteditor (HTML edtor using TinyMCE)
      2. Add images, upload files to link to.
      3. Check that you can pick those files again using repository "Embedded files"
      4. Check that you can manage those files using "Manage files" button in TinyMCE
      5. Try replacing, removing, renaming files, adding new there.
      6. Make sure error is displayed when file is missing
      7. Delete links to the embedded files
      8. Open "Manage files" window, make sure it offers to delete the files as well
      9. Make sure the form is saved with all files, files are displayed in view mode and text can be edited again

      Test 2. Textareas with supported subdirs:
      editors in all classes extending question_edit_form support subfolders. They are not used now but may contain files in subfolders after the upgrade from ancient versions of Moodle.

      1. Create quesiton
      2. Enter some text, embed files
      3. Open "Manage files" and create subfolders, place files in them
      4. Make sure you can link to those files using "Embedded files" repository
      5. Make sure form can be saved, files are properly displayed, text can be edited again.
      6. Try placing extra files in subfolders or removing used files
      7. Make sure all warnings/information appear in "Manage files" form.
      Show
      Test required for two new plugins: tinymce_managefiles and repository_areafiles. Test 1. Basic editor Open any form with empty texteditor (HTML edtor using TinyMCE) Add images, upload files to link to. Check that you can pick those files again using repository "Embedded files" Check that you can manage those files using "Manage files" button in TinyMCE Try replacing, removing, renaming files, adding new there. Make sure error is displayed when file is missing Delete links to the embedded files Open "Manage files" window, make sure it offers to delete the files as well Make sure the form is saved with all files, files are displayed in view mode and text can be edited again Test 2. Textareas with supported subdirs: editors in all classes extending question_edit_form support subfolders. They are not used now but may contain files in subfolders after the upgrade from ancient versions of Moodle. Create quesiton Enter some text, embed files Open "Manage files" and create subfolders, place files in them Make sure you can link to those files using "Embedded files" repository Make sure form can be saved, files are properly displayed, text can be edited again. Try placing extra files in subfolders or removing used files Make sure all warnings/information appear in "Manage files" form.
    • Workaround:
      Hide

      Use plugins:
      Moodle 2.4-2.5:

      Moodle 2.0-2.3:

      Show
      Use plugins: Moodle 2.4-2.5: Repository "Embedded files" https://moodle.org/plugins/view.php?plugin=repository_areafiles TinyMCE plugin "Manage embedded files" https://moodle.org/plugins/view.php?plugin=tinymce_managefiles Moodle 2.0-2.3: Repository "Embedded files plus": https://moodle.org/plugins/view.php?plugin=repository_areafilesplus
    • Difficulty:
      Difficult
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      wip-MDL-28019-master

      Description

      User are not able to:
      1/ delete "uploaded" file
      2/ user can not find out what files were already uploaded
      3/ users can not link again already existing image

      The reason is that there is no way to manage the files that are uploaded to the file area referenced from the text in tinymce editor. Attempts to work around this missing feature (overriding of files, link from forms, etc.) were only creating regressions.

      Possible solution - add a new tab "Used files" to the file picker, this would solve all 3 issues above. I have proposed several different solutions before, but I think this is the best one.

        Gliffy Diagrams

          Attachments

          1. debugging_using_embedded.png
            debugging_using_embedded.png
            31 kB
          2. picker.png
            picker.png
            23 kB
          3. picker2.png
            picker2.png
            307 kB
          4. question_from_1_9_backup.png
            question_from_1_9_backup.png
            35 kB

            Issue Links

              Activity

                People

                • Votes:
                  145 Vote for this issue
                  Watchers:
                  57 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    18/Nov/13