Moodle
  1. Moodle
  2. MDL-28035

Upgrade site with 1 simple adaptive mode quiz from 2.0 to 2.1 breaks badly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1
    • Component/s: Questions, Quiz
    • Labels:
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      1. Create some adaptive quizzes in 2.0.
      2. Attempt them as student.

      3. Backup this up, and restore to 2.1. Make sure the attempts are upgraded OK during the restore.
      4. Regrade the restored attempts, and make sure the score does not change.

      5. Upgrade the 2.0 site to 2.1. Make sure the attempts are upgraded OK during the restore.
      6. Regrade the restored attempts, and make sure the score does not change.

      Show
      1. Create some adaptive quizzes in 2.0. 2. Attempt them as student. 3. Backup this up, and restore to 2.1. Make sure the attempts are upgraded OK during the restore. 4. Regrade the restored attempts, and make sure the score does not change. 5. Upgrade the 2.0 site to 2.1. Make sure the attempts are upgraded OK during the restore. 6. Regrade the restored attempts, and make sure the score does not change.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      18010

      Description

      To reproduce:

      • Install 20_STABLE site from scratch
      • Create one course, 1 teacher and 2 students
      • As teacher, create on quiz with only one true/false question - with Adaptive mode On.
      • As students, perform some attempts (1 correct and 1 incorrect at least)
      • Check that changing between highest and average grade does its job.
      • Save one backup of the course in a safe place (needed for MDL-28037)
      • Upgrade the site to 2.1
      • Go to the quiz and perform one "regrade all"

      Expected:

      • Nothing should change, old grades should be the same from last recalculation in 20_STABLE

      Current:

      • Grades change showing 0% no matter the answer was correct / incorrect. The responses report shows "-" for the "true" correct answers originally. Reviewing the attempt it shows correct feedback but evaluates it as incorrect with 0 mark points.

        Issue Links

          Activity

          Hide
          Tim Hunt added a comment -

          Sorry to have to push such a scary change now.

          Show
          Tim Hunt added a comment - Sorry to have to push such a scary change now.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I don't get the logic beyond those tiny changes, but relying strongly in all your test passing, this is integrated.

          74/78 test cases complete: 2217 passes, 0 fails and 0 exceptions.

          (not sure about the 74/78, btw)

          Show
          Eloy Lafuente (stronk7) added a comment - I don't get the logic beyond those tiny changes, but relying strongly in all your test passing, this is integrated. 74/78 test cases complete: 2217 passes, 0 fails and 0 exceptions. (not sure about the 74/78, btw)
          Hide
          Glenn Ansley added a comment -

          This test technically worked correctly so I'm passing it. In the course of testing it, however, two other bugs were exposed. I confirmed this with Tim and will create and link to those tickets here.

          Show
          Glenn Ansley added a comment - This test technically worked correctly so I'm passing it. In the course of testing it, however, two other bugs were exposed. I confirmed this with Tim and will create and link to those tickets here.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Have you cheated the Tracker to appear in all the issues, Tim?

          Thanks everybody!

          Show
          Eloy Lafuente (stronk7) added a comment - Have you cheated the Tracker to appear in all the issues, Tim? Thanks everybody!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: