Details
-
Type:
Improvement
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.0.3, 2.1, 2.2
-
Fix Version/s: 2.1.1
-
Labels:
-
Testing Instructions:
-
Difficulty:Moderate
-
Affected Branches:MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
-
Fixed Branches:MOODLE_21_STABLE
-
Pull from Repository:
-
Pull Master Branch:glossary_multilang_master
-
Pull Master Diff URL:
Description
Using "FAQ" in glossary module, the new created categories cannot be displayed correctly in multiple languages using multilang filter. (<span class="multilang" lang="en">...</span> ....)
In the heading, it shows the hole code.
In the drop-down box, it shows all languages one after another (but without code).
####################
UPDATE (28 June 11):
####################
Screenshot 1: Shows the category drop-down-box on the right with both languages one after another; in addition, you can see the chosen category in the middle showing the hole code. To fix both of these bugs, add some "format_string()" to /mod/glossary/lib.php
line 1675: $menu[$url] = clean_text(format_string($currentcategory->name));
line 1683: echo format_text(format_string($category->name), FORMAT_PLAIN);
(Attention: These lines are refering to the glossary module version 2010111501. In older or newer versions, the lines may differ!)
Screenshot 2: When editing categories, the overview shows the hole multilang code. In addition, if you try to delete a category, the confirmation page also shows the hole code. Both bugs can also be fixed with some format_string() calls added to /mod/glossary/editcategories.php
line 218: echo "<span class=\"bold\">".format_text(format_string($category->name), FORMAT_PLAIN)."</span> <span>($num_entries " . get_string("entries","glossary") . ")</span>";
line 121: echo "<div class=\"boxaligncenter deletecatconfirm\">".format_text(format_string($category->name), FORMAT_PLAIN)."<br/>";
(Attention: These lines are refering to the glossary module version 2010111501. In older or newer versions, the lines may differ!)
Screenshot 3: The category headings also show all languages one after another. I didn't find a fix for that until now.
Activity
Hi, I'm submitting this for integration for 21_STABLE and master. I think I've fixed all the occurrences of categories so they now support the multilang properly (by configuring such setting to process both content and headings).
Anyway, note I'm not happy at all with this sort of solution, as far as the rest of the glossary logic is not prepared to support those multilang strings 100%. Nor in categories, nor concepts, nor aliases. Surely it's a matter of do a serious analysis if this should become a "native" feature of the glossary instead of all these hacks that only makes it slower and prone to errors (for example, filters behavior against that type of contents, is not supported at all).
Ciao 
Yay for more hacks - integrated anyway as it looks to fix the problem at hand, Thanks Eloy
Thanks for reporting that. You reported a problem with multi-lang strings for my contributed block, the Progress Bar block. Thanks for being so diligent with such testing.
I've put it on our backlog and we'll try to get to it as soon as we can.
In the meantime adding more information, such as screenshots, replication instructions, fix test instructions, a workaround or even a code solution, will help us and other users.