Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28049

Missing include in question/format/xml breaks third-party question types

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.1
    • 2.1
    • Questions
    • None
    • MOODLE_21_STABLE
    • MOODLE_21_STABLE
    • Hide

      1. install a third-party qtype, like https://github.com/timhunt/moodle-qtype_gapselect/
      2. Go to Site administration > Plugins > Question types > Manage question types and check it is not broken.

      Also repeat the tests for MDL-27956.

      Do similar tests for importing/exporting into the real question bank.

      Show
      1. install a third-party qtype, like https://github.com/timhunt/moodle-qtype_gapselect/ 2. Go to Site administration > Plugins > Question types > Manage question types and check it is not broken. Also repeat the tests for MDL-27956 . Do similar tests for importing/exporting into the real question bank.

    Description

      This is a regression from MDL-27956. The changes there broke third-party question types because of a missing require_once.

      Unfortunately, adding the require_once breaks the lesson module.

      The discussion in MDL-27956 concluded that a conditional include was the least bad change to try and get everything working in 2.1, but it is not very nice.

      Attachments

        Activity

          People

            timhunt Tim Hunt
            timhunt Tim Hunt
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Safat Shahin, Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              1/Jul/11