Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28049

Missing include in question/format/xml breaks third-party question types

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1
    • Component/s: Questions
    • Labels:
      None
    • Testing Instructions:
      Hide

      1. install a third-party qtype, like https://github.com/timhunt/moodle-qtype_gapselect/
      2. Go to Site administration > Plugins > Question types > Manage question types and check it is not broken.

      Also repeat the tests for MDL-27956.

      Do similar tests for importing/exporting into the real question bank.

      Show
      1. install a third-party qtype, like https://github.com/timhunt/moodle-qtype_gapselect/ 2. Go to Site administration > Plugins > Question types > Manage question types and check it is not broken. Also repeat the tests for MDL-27956 . Do similar tests for importing/exporting into the real question bank.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      This is a regression from MDL-27956. The changes there broke third-party question types because of a missing require_once.

      Unfortunately, adding the require_once breaks the lesson module.

      The discussion in MDL-27956 concluded that a conditional include was the least bad change to try and get everything working in 2.1, but it is not very nice.

        Attachments

          Activity

            People

            • Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Tim Hunt, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                1/Jul/11