Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28055

Missing library includes in quiz upgrade from 1.9 to 2.1

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.1
    • 2.1
    • Quiz
    • MOODLE_21_STABLE
    • MOODLE_21_STABLE
    • Hide

      This is actually really hard to test, unless you do have a very old Moodle around. Anyway, this is the correct testing procedure. I must admin that I could not be bothered to do it myself:

      1. Install Moodle 1.4.
      2. Create a quiz, attempt it as a student. Perhaps complete one attempt, and leave another one in mid-attempt.
      3. Upgrade to 1.9, which probably involves going via 1.6 and Unicode upgrade.
      – Keep a backup of this Moodle site in this state, so we can repeat the test if necessary.
      4. Upgrade to 2.1. Verify no errors occur. Verify that when you review the quiz attempts, it all looks OK.

      If there are any problems, go back to the 1.9 backup, and see if the problem was in the upgrade 1.9 -> 2.1 or earlier than that. If it was earlier than that, it will be deeply depressing.

      Alternatively, we could just hope that Henning Bostelmann (who reported the bug) is able to test these changes for us.

      Show
      This is actually really hard to test, unless you do have a very old Moodle around. Anyway, this is the correct testing procedure. I must admin that I could not be bothered to do it myself: 1. Install Moodle 1.4. 2. Create a quiz, attempt it as a student. Perhaps complete one attempt, and leave another one in mid-attempt. 3. Upgrade to 1.9, which probably involves going via 1.6 and Unicode upgrade. – Keep a backup of this Moodle site in this state, so we can repeat the test if necessary. 4. Upgrade to 2.1. Verify no errors occur. Verify that when you review the quiz attempts, it all looks OK. If there are any problems, go back to the 1.9 backup, and see if the problem was in the upgrade 1.9 -> 2.1 or earlier than that. If it was earlier than that, it will be deeply depressing. Alternatively, we could just hope that Henning Bostelmann (who reported the bug) is able to test these changes for us.

    Description

      While upgrading a Moodle 1.9 database to Moodle 2.1(beta), during the mod/quiz upgrade, the following error is encountered.

      Fatal error: Call to undefined function quiz_upgrade_very_old_question_sessions() in /home/bostelm/apps/git/mathsmoodle.git/mod/quiz/db/upgrade.php on line 574

      It appears that the script doesn't include upgradelib.php in the same directory. (However, I tried to include this library and this only leads to a different "undefined function" error.)

      Attachments

        Issue Links

          Activity

            People

              timhunt Tim Hunt
              bostelm Henning Bostelmann
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Anthony Borrow Anthony Borrow
              Tim Hunt, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Kevin Percy, Laurent David, Mathew May, Mihail Geshoski, Raquel Ortega, Sabina Abellan, Sander Bangma, Sara Arjona (@sarjona), Shamim Rezaie
              Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                1/Jul/11