Moodle
  1. Moodle
  2. MDL-28062

Searching and then grading a Glossary entry gets an error: Must specify glossary ID or course module ID

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.12
    • Fix Version/s: 1.9.13
    • Component/s: Glossary
    • Labels:
    • Environment:
      Moodle 1.9.11+ (Build: 20110420) and 1.9.12+ (Build: 20110518)
    • Testing Instructions:
      Hide
      1. Create one graded glossary
      2. As student introduce some entries
      3. As teacher perform one search and get X entries listed
      4. Rate some of them
      5. Click: "Send my latest ratings" and, attention:
      6. TEST: You should see message: "Ratings saved (continue)"
      7. TEST: 2 seconds (aprox) later, you are redirected back to the glossary, EXACTLY to the search page performed above.
      8. TEST: The ratings are show properly.
      Show
      Create one graded glossary As student introduce some entries As teacher perform one search and get X entries listed Rate some of them Click: "Send my latest ratings" and, attention: TEST: You should see message: "Ratings saved (continue)" TEST: 2 seconds (aprox) later, you are redirected back to the glossary, EXACTLY to the search page performed above. TEST: The ratings are show properly.
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Pull from Repository:
    • Rank:
      17743

      Description

      When searching a glossary and then grading a glossary entry the following error appears:

      Must specify glossary ID or course module ID

      Note:
      a) The grade is saved despite the error
      b) this error only appears after searching a glossary and then trying to save a grade
      c) this error appears in 1.9.11+ (Build: 20110420) and 1.9.12+ (Build: 20110518)
      d) one of the glossaries I tested has the URL of http://tel.c.fun.ac.jp/moodle/mod/glossary/view.php?id=40
      BUT after searching the URL becomes http://tel.c.fun.ac.jp/moodle/mod/glossary/view.php
      i.e. no ID number

      To reproduce this error:
      1) create a glossary: see attached screenshot for settings
      2) Allow entries to be rated = Yes
      3) Have a student Add a new entry
      4) Search for this entry
      5) Have a teacher grade this entry & click on the [Send in my latest ratings] button
      6) the grade is saved, then the following error message appears: "Must specify glossary ID or course module ID"

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this.

        I've put it on our backlog and we'll try to get to it as soon as we can.

        Sounds like the redirect after a save is not getting the information it needs.

        Adding more information, such as screenshots or even a code solution, will help us and other users.

        Show
        Michael de Raadt added a comment - Thanks for reporting this. I've put it on our backlog and we'll try to get to it as soon as we can. Sounds like the redirect after a save is not getting the information it needs. Adding more information, such as screenshots or even a code solution, will help us and other users.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Sending to integration. Note this does not affect 2.x series at all.

        Show
        Eloy Lafuente (stronk7) added a comment - Sending to integration. Note this does not affect 2.x series at all.
        Hide
        Sam Hemelryk added a comment -

        Thanks Eloy. Integrated now

        Show
        Sam Hemelryk added a comment - Thanks Eloy. Integrated now
        Hide
        Andrew Davis added a comment -

        Looks good

        Show
        Andrew Davis added a comment - Looks good
        Hide
        Sam Hemelryk added a comment -

        Congratulations - this fix has just been released in the weeklies.

        Show
        Sam Hemelryk added a comment - Congratulations - this fix has just been released in the weeklies.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: