Loading...

XML

Word

Printable

Affected Branches:
MOODLE_20_STABLE
Fixed Branches:
MOODLE_24_STABLE
Pull from Repository:
git://github.com/ankitagarwal/moodle.git
Pull Main Branch:
~~MDL-28071~~-master
Pull Main Diff URL:
https://github.com/ankitagarwal/moodle/compare/MDL-28071-master
Testing Instructions:
Hide

goto calendar and click on new event

make sure the form is divided into three fieldsets with legends "general" , "duration", "repeated events" respectively

verify the same for the form to edit a repeated event

Verify the form to edit a non-repeated element has two fieldset with legend "general" and "duration"
Show
goto calendar and click on new event make sure the form is divided into three fieldsets with legends "general" , "duration", "repeated events" respectively verify the same for the form to edit a repeated event Verify the form to edit a non-repeated element has two fieldset with legend "general" and "duration"

the label on 'date' does not have 'for' attribute and the fieldset around the date controls does not have a legend. I think it would be preferable if the word 'date' was the legend for the fieldset.

there are two instances of <label for="id_e3062b"> on 'duration' but as I understand it these should be unique. Same applies to 'until', 'Duration in minutes', 'Repeat this event' and 'Repeat weekly, creating altogether', and 'save changes'.

There should be a fieldset for the duration radio buttons and the word 'duration' should be the legend for the fieldset.

there is an empty label tag after 'until' and before 'day' (this may be because day is currently greyed out).

The whole form is within a fieldset which does not have a legend, but I would not normally suggest placing a whole form within this tag.

will be (partly) resolved by

MDL-35559 META: Upgrade Forms

Participants:: Ankit Agarwal, Dan Poltawski, Frédéric Massart, Jason Fowler, Jenny Gray, Sam Hemelryk