Moodle
  1. Moodle
  2. MDL-28081

Visible line break tag in coursehelpnewsitemsnumber

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: None
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as administrator
      2. In the Settings menu, expand "Site administration"
      3. Expand Courses
      4. Click on "Course default settings"
      5. Find the setting for "Items to Show" and note that no <br/> tag should be visible.
      Show
      Log in as administrator In the Settings menu, expand "Site administration" Expand Courses Click on "Course default settings" Find the setting for "Items to Show" and note that no <br/> tag should be visible.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE
    • Pull Master Branch:
      wip-mdl-28081
    • Rank:
      17706

      Description

      The break tag in $string['coursehelpnewsitemsnumber'] doesn't have spaces around it and thus doesn't render correctly in Course Default Settings > News Items to Show.

      2.1 patch: https://github.com/mackensen/moodle/commit/eddd0574525d71fdaef552760f954c0b3cd7e11a.

      Replication instructions:

      1. Log in as administrator
      2. In the Settings menu, expand "Site administration"
      3. Expand Courses
      4. Click on "Course default settings"
      5. Find the setting for "Items to Show" and note that it includes a visible <br/> tag.

        Issue Links

          Activity

          Hide
          Filter Manager added a comment -

          Thanks for reporting this.

          I've put it on our backlog and we'll try to get to it as soon as we can.

          Show
          Filter Manager added a comment - Thanks for reporting this. I've put it on our backlog and we'll try to get to it as soon as we can.
          Hide
          Michael de Raadt added a comment -

          Sorry, I was still logged in as Filter Manger when I wrote the comment above.

          It really was me

          Michael;

          Show
          Michael de Raadt added a comment - Sorry, I was still logged in as Filter Manger when I wrote the comment above. It really was me Michael;
          Hide
          Rajesh Taneja added a comment -

          Thanks Charles, for providing the patch. It's spot-on

          I have applied the patch provided by you on 2.0, 2.1 and master.

          Show
          Rajesh Taneja added a comment - Thanks Charles, for providing the patch. It's spot-on I have applied the patch provided by you on 2.0, 2.1 and master.
          Hide
          Sam Hemelryk added a comment -

          Looks great to me thanks guys

          Show
          Sam Hemelryk added a comment - Looks great to me thanks guys
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Rajesh Taneja added a comment -

          Fixed By Tim as part of MDL-25357 patch

          Show
          Rajesh Taneja added a comment - Fixed By Tim as part of MDL-25357 patch

            People

            • Votes:
              17 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: