Moodle
  1. Moodle
  2. MDL-28087

Improve Jabber message friendliness

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1
    • Component/s: Messages
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      Use the replication instructions. Note that you need to wait for "maxeditingtime" minutes to pass after grading the student submission before you run cron. max editing time is a server settting.

      Show
      Use the replication instructions. Note that you need to wait for "maxeditingtime" minutes to pass after grading the student submission before you run cron. max editing time is a server settting.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull Master Branch:
      MDL-28087_friendly_jabber
    • Rank:
      18073

      Description

      From Eloy...

      I received exactly this:

      [21:59:19] <Eloy Bot> Admin User: TC: Assignments: Upload 1 file assignment 
      View: http://127.0.0.1/~stronk7/integration/mod/assignment/view.php?id=664
      (Do not reply to this message)
      

      BUT really I think we should generate some more "friendly" message, like:

      Message from XXX about activity XXXXX. Your submission has been graded. View: http://xxxx.xxx.xxx for more info
      (do not reply to this messge)
      

      Replication instructions:

      1. Establish a Jabber server with the Web server
      2. Set up an assignment
      3. Log in as student
      4. Browse to Settings -> My profile settings -> Messaging
      5. Check jabber as a notification method (logged in and offline) for assignment notifications
      6. Submit to assignment
      7. Log in as a admin
      8. Provide feedback on student's submission
      9. Force cron by visiting http://yourserver/admin/cron.php
      10. Look at feedback message sent via Jabber

        Issue Links

          Activity

          Hide
          Andrew Davis added a comment -

          Oops. I opened one two. MDL-28088. have closed that one and Ill fix this one

          Show
          Andrew Davis added a comment - Oops. I opened one two. MDL-28088 . have closed that one and Ill fix this one
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Hide
          Aparup Banerjee added a comment -

          behold the beauty of jabber

          (17:01:55) hqtest@messaging.moodle.org/moodle: Admin User: Admin User has posted some feedback on your
          assignment submission for 'advanced file upload' You can see it appended to your submission
          View: http://aparup.moodle.local/m20/mysql/moodle/mod/assignment/view.php?id=133
          (Do not reply to this message)

          its more informative for sure! should we allow message templating? :-D

          Show
          Aparup Banerjee added a comment - behold the beauty of jabber (17:01:55) hqtest@messaging.moodle.org/moodle: Admin User: Admin User has posted some feedback on your assignment submission for 'advanced file upload' You can see it appended to your submission View: http://aparup.moodle.local/m20/mysql/moodle/mod/assignment/view.php?id=133 (Do not reply to this message) its more informative for sure! should we allow message templating? :-D
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Yay, this is now part of the just released Moodle 2.1 ! Thanks for all the hard work!

          Show
          Eloy Lafuente (stronk7) added a comment - Yay, this is now part of the just released Moodle 2.1 ! Thanks for all the hard work!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: