Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.0.3, 2.1, 2.2
-
Component/s: SCORM
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
-
Fixed Branches:MOODLE_20_STABLE, MOODLE_21_STABLE
-
Pull from Repository:
-
Pull Master Branch:master_
MDL-28110 -
Pull Master Diff URL:
Description
Traditionally Moodle has been designed so that "everything" works with JS disabled..
We've added a new option to settings > plugins > activity Modules > SCORM package to prevent access to SCORM objects if JS is disabled in a users browser - this setting is disabled by default but I'd like to change it to enabled by default for new installs/upgrades.
if a user has JS disabled it doesn't store any grading information - it does print a notice to the user to let them know, but usually they ignore this.
Gliffy Diagrams
Attachments
Issue Links
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
+1 to switch the default from forcejavascript = false to true if:
1) It's done for new installations only.
2) The setting includes help string explaining the difference (prevent run completely versus allow run without API communication)
Ciao 
thanks - integration request submitted - it should probably wait until after 2.1 release, I will rebase when the next integration is complete.
Hi Dan,
I was to integrate this but then I remembered we had some sort of rule for help strings in admin settings, so start looking.
It seems they should be, since 2.0: xxxx_desc. So better I halt and allow you to fix that tiny detail.
Reference: http://docs.moodle.org/dev/Help_strings#String_names
Ciao
thanks Eloy - have fixed that up.
MDL-28111 must be integrated first - the master branch has been merged with those changes already.
Here we go, integrated, thanks! (20, 21 and master)
looks good. forcejavascript is indeed enabled on a clean install.
Moodle's git/cvs repositories have been updated with this piece of art! Thanks!
btw - the setting in 2.0 is SCORM -> forcejavascript