Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1, 2.2
    • Fix Version/s: 2.0.4, 2.1.1
    • Component/s: SCORM
    • Labels:

      Description

      Traditionally Moodle has been designed so that "everything" works with JS disabled..

      We've added a new option to settings > plugins > activity Modules > SCORM package to prevent access to SCORM objects if JS is disabled in a users browser - this setting is disabled by default but I'd like to change it to enabled by default for new installs/upgrades.

      if a user has JS disabled it doesn't store any grading information - it does print a notice to the user to let them know, but usually they ignore this.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Dan Marsden added a comment -

            btw - the setting in 2.0 is SCORM -> forcejavascript

            Show
            Dan Marsden added a comment - btw - the setting in 2.0 is SCORM -> forcejavascript
            Hide
            Eloy Lafuente (stronk7) added a comment -

            +1 to switch the default from forcejavascript = false to true if:

            1) It's done for new installations only.
            2) The setting includes help string explaining the difference (prevent run completely versus allow run without API communication)

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - +1 to switch the default from forcejavascript = false to true if: 1) It's done for new installations only. 2) The setting includes help string explaining the difference (prevent run completely versus allow run without API communication) Ciao
            Hide
            Dan Marsden added a comment -

            thanks - integration request submitted - it should probably wait until after 2.1 release, I will rebase when the next integration is complete.

            Show
            Dan Marsden added a comment - thanks - integration request submitted - it should probably wait until after 2.1 release, I will rebase when the next integration is complete.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Hi Dan,

            I was to integrate this but then I remembered we had some sort of rule for help strings in admin settings, so start looking.

            It seems they should be, since 2.0: xxxx_desc. So better I halt and allow you to fix that tiny detail.

            Reference: http://docs.moodle.org/dev/Help_strings#String_names

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Hi Dan, I was to integrate this but then I remembered we had some sort of rule for help strings in admin settings, so start looking. It seems they should be, since 2.0: xxxx_desc. So better I halt and allow you to fix that tiny detail. Reference: http://docs.moodle.org/dev/Help_strings#String_names Ciao
            Hide
            Dan Marsden added a comment -

            thanks Eloy - have fixed that up.

            Show
            Dan Marsden added a comment - thanks Eloy - have fixed that up.
            Hide
            Dan Marsden added a comment -

            MDL-28111 must be integrated first - the master branch has been merged with those changes already.

            Show
            Dan Marsden added a comment - MDL-28111 must be integrated first - the master branch has been merged with those changes already.
            Show
            Dan Marsden added a comment - 2.1 Branch: m21_ MDL-28110 https://github.com/danmarsden/moodle/compare/MOODLE_21_STABLE...m21_MDL-28110
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Here we go, integrated, thanks! (20, 21 and master)

            Show
            Eloy Lafuente (stronk7) added a comment - Here we go, integrated, thanks! (20, 21 and master)
            Hide
            Andrew Davis added a comment -

            looks good. forcejavascript is indeed enabled on a clean install.

            Show
            Andrew Davis added a comment - looks good. forcejavascript is indeed enabled on a clean install.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Moodle's git/cvs repositories have been updated with this piece of art! Thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Moodle's git/cvs repositories have been updated with this piece of art! Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: