Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.3
    • Fix Version/s: 2.2
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide

      This can't easily be tested - it only changes structure of code/tidies it up a bit.

      would be a good idea to just run through a standard SCORM to make sure it functions correctly.

      Show
      This can't easily be tested - it only changes structure of code/tidies it up a bit. would be a good idea to just run through a standard SCORM to make sure it functions correctly.
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      master_MDL-28111
    • Rank:
      17731

      Description

      lots of the SCORM code has bad tabs, missing boilerplates - tidy up time....

        Issue Links

          Activity

          Hide
          Dan Marsden added a comment -

          still a lot more to go, but this is a good whack. - ignoring sequencinglib.php for now

          btw - this should wait until after 2.1 release - I'll rebase it after this weeks integration is complete.

          Show
          Dan Marsden added a comment - still a lot more to go, but this is a good whack. - ignoring sequencinglib.php for now btw - this should wait until after 2.1 release - I'll rebase it after this weeks integration is complete.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          wow, yes. it's huge, Surely better do it @ master and some day backport (optionally). And after releasing and branching 21_STABLE.

          Thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - wow, yes. it's huge, Surely better do it @ master and some day backport (optionally). And after releasing and branching 21_STABLE. Thanks!
          Hide
          Dan Marsden added a comment -

          thanks Eloy - I'm hoping that 21_STABLE is branched quickly.

          Show
          Dan Marsden added a comment - thanks Eloy - I'm hoping that 21_STABLE is branched quickly.
          Hide
          Dan Marsden added a comment -

          rebased against latest master.

          Show
          Dan Marsden added a comment - rebased against latest master.
          Hide
          Dan Marsden added a comment -

          it would be helpful if this wasn't rebased further - esp as it is used in the patch for MDL-28110

          Show
          Dan Marsden added a comment - it would be helpful if this wasn't rebased further - esp as it is used in the patch for MDL-28110
          Hide
          Dan Marsden added a comment -

          2.1 Stable code:
          m21_MDL-28111
          https://github.com/danmarsden/moodle/compare/MOODLE_21_STABLE...m21_MDL-28111

          this doesn't need to go into 2.0Stable. - thanks.

          Show
          Dan Marsden added a comment - 2.1 Stable code: m21_ MDL-28111 https://github.com/danmarsden/moodle/compare/MOODLE_21_STABLE...m21_MDL-28111 this doesn't need to go into 2.0Stable. - thanks.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          After reviewing it (it's the whole thing), we have agreed it's better to apply this only to master.

          Surely we are being ultra-safer here and we could backport it to 21_STABLE but, at the end this goes only to master.

          Given the TTL of releases is 1y this only will cause all sort of headaches to Dan Marsen along that period. Remember Dan, you agreed! LOL.

          Show
          Eloy Lafuente (stronk7) added a comment - After reviewing it (it's the whole thing), we have agreed it's better to apply this only to master. Surely we are being ultra-safer here and we could backport it to 21_STABLE but, at the end this goes only to master. Given the TTL of releases is 1y this only will cause all sort of headaches to Dan Marsen along that period. Remember Dan, you agreed! LOL.
          Hide
          Andrew Davis added a comment -

          This looks good so far as I can tell.

          Show
          Andrew Davis added a comment - This looks good so far as I can tell.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Moodle's git/cvs repositories have been updated with this piece of art! Thanks!

          PS: Surely "art" is way too much for this, lol!

          Show
          Eloy Lafuente (stronk7) added a comment - Moodle's git/cvs repositories have been updated with this piece of art! Thanks! PS: Surely "art" is way too much for this, lol!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: