Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28134

relying on $release and regex to get the version to point to within docs too dependant on formatting of release.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.9.13, 2.0.4, 2.1
    • Fix Version/s: 2.3
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide

      1)start a fresh installation of moodle
      2)on the installation pages, check that all links to docs.moodle.org (everypage has one at the bottom) are correct for the version of moodle.
      3) after installation, check that pages have the correct link to its docs page - correct version too.

      test on web as well as cli based installations/upgrades.

      Show
      1)start a fresh installation of moodle 2)on the installation pages, check that all links to docs.moodle.org (everypage has one at the bottom) are correct for the version of moodle. 3) after installation, check that pages have the correct link to its docs page - correct version too. test on web as well as cli based installations/upgrades.
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-28134_branch

      Description

      mentioned in MDL-28044 : http://tracker.moodle.org/browse/MDL-28044?focusedCommentId=115425&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-115425

      Eloy said:
      "3) And the most I think on it... the less I like (this applies to all branches, not only 19_STABLE) the include of version.php at all nor the parsing of $release to calculate $branch. After all, each branch has different code and we could have some constant/define with the 19/20... That would make everything really easy IMO.
      .. about the 19_STABLE problem and the version.php consideration. Just imagine we invent version 10.1 or whatever, that will break the regexp, while having it in some constant will do things really easier and free of problems loading version.php multiple times or so."

      it certainly makes more sense to define a specific branch variable to me. (sole purpose is for linking to docs initially?)

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12