[MDL-28138] format_float function in question/type/calculated/db/upgradelib.php seems broken - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_21_STABLE
Fixed Branches:
MOODLE_21_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-28138~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-28138
Testing Instructions:

Hide

1. Run the unit tests in question
2. Create calculated and calculated multi questions with various settings for 'Correct answer shows' and answer Format.
3. Preview the question, and ensure that the answers are formatted properly.
4. Switch to a language that uses , as decimal point, and re-preview the question.

5. Test the upgrade 2.0 to 2.1 including attempts at calculated questions, and make sure there are no errors.

Show
1. Run the unit tests in question 2. Create calculated and calculated multi questions with various settings for 'Correct answer shows' and answer Format. 3. Preview the question, and ensure that the answers are formatted properly. 4. Switch to a language that uses , as decimal point, and re-preview the question. 5. Test the upgrade 2.0 to 2.1 including attempts at calculated questions, and make sure there are no errors.

format_float function in

If and else if have same condition in function format_float.

public function format_float($x, $length = null, $format = null) {

    if (!is_null($length) && !is_null($format)) {

        if ($format == 1) {

            // Decimal places.

            $x = sprintf('%.' . $length . 'F', $x);

        } else if ($format == 1) {

            // Significant figures.

            $x = sprintf('%.' . $length . 'g', $x);

            $x = str_replace(',', '.', $x);

    return $x;

has a non-specific relationship to

MDL-27418 apply_unit() does not handle well is_numeric() valid numbers when decsep = ,

Participants:: Eloy Lafuente (stronk7), Rajesh Taneja, Sam Hemelryk, Tim Hunt

Component watchers:: Safat Shahin, Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie