Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28145

The (commented out) 'rendererfactory' stub is wrong in several theme config.php

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1
    • Fix Version/s: 2.0.4, 2.1.1
    • Component/s: Themes
    • Labels:

      Description

      In several themes' config.php files the stub for $THEME->renderrerfactory is incorrectly stated as $THEME->renderfactory. If you don't notice, this will result in a theme renderrer not working and no error messages.

      Applies here: (grep search)

      arialist/config.php:252:// $THEME->renderfactory
      binarius/config.php:247:// $THEME->renderfactory
      boxxie/config.php:221:// $THEME->renderfactory
      brick/config.php:243:// $THEME->renderfactory
      canvas/config.php:262:// $THEME->renderfactory
      formfactor/config.php:227:// $THEME->renderfactory
      fusion/config.php:248:// $THEME->renderfactory
      leatherbound/config.php:236:// $THEME->renderfactory
      magazine/config.php:202:// $THEME->renderfactory
      nimble/config.php:248:// $THEME->renderfactory
      nonzero/config.php:247:// $THEME->renderfactory
      overlay/config.php:242:// $THEME->renderfactory
      serenity/config.php:108:// $THEME->renderfactory
      sky_high/config.php:246:// $THEME->renderfactory

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for reporting this.

            I've put it on our backlog and we'll try to get to it as soon as we can.

            Show
            salvetore Michael de Raadt added a comment - Thanks for reporting this. I've put it on our backlog and we'll try to get to it as soon as we can.
            Hide
            skodak Petr Skoda added a comment -

            Thanks a lot for your report, btw I was first looking for your "renderrerfactory" but it was "rendererfactory", ciao!

            Show
            skodak Petr Skoda added a comment - Thanks a lot for your report, btw I was first looking for your "renderrerfactory" but it was "rendererfactory", ciao!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks guys, this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks guys, this has been integrated now
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Passing testing as there isn't anything to test!

            Show
            samhemelryk Sam Hemelryk added a comment - Passing testing as there isn't anything to test!
            Hide
            skodak Petr Skoda added a comment -

            Thanks everybody, this is now part of the weekly build.

            Show
            skodak Petr Skoda added a comment - Thanks everybody, this is now part of the weekly build.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  1/Aug/11