[MDL-28155] Can't implement "download all submissions" feature in non-standard assignment type - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.0.3, 2.1
Fix Version/s: 2.2.5, 2.3.2
Component/s: Assignment (2.2)
Labels:
- patch
- triaged

Affected Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/dmonllao/moodle.git
Pull Master Branch:
~~MDL-28155~~_master
Pull Master Diff URL:
https://github.com/dmonllao/moodle/compare/master...MDL-28155_master
Difficulty:
Easy
Testing Instructions:
Hide

Create an online assignment (Assignment 2.2 in Moodle > 2.2)

Login as a student make a submission to the assignment

As a teacher / admin, go to the assignment and click "View N submitted assignments" you SHOULD see the 'Download submissions' link

Create an offline assignment (Assignment 2.2 in Moodle > 2.2)

As a teacher / admin, go to the assignment and click "View assignment grades and feedback" you SHOULD NOT see the 'Download all assignments' link

Create an extension of the online assignment type

cp -r mod/assignment/type/online mod/assignment/type/onlinetest

Edit mod/assignment/type/onlinetest/version.php changing plugin->component to 'assignment_onlinetest'

Edit mod/assignment/type/onlinetest/assignment.class.php changing the classes names to 'assignment_onlinetest' and 'mod_assignment_onlinetest_edit_form', and the call to 'mod_assignment_online_edit_form' to 'mod_assignment_onlinetest_edit_form'

Click notifications to install the plugin

Create a new onlinetest assignment, there will be missing text strings, it's a test

Login as a student and add a submission

As a teacher / admin, go to the assignment and click "View N submitted assignments" you SHOULD see the "Download all assignments" link
Show
Create an online assignment (Assignment 2.2 in Moodle > 2.2) Login as a student make a submission to the assignment As a teacher / admin, go to the assignment and click "View N submitted assignments" you SHOULD see the 'Download submissions' link Create an offline assignment (Assignment 2.2 in Moodle > 2.2) As a teacher / admin, go to the assignment and click "View assignment grades and feedback" you SHOULD NOT see the 'Download all assignments' link Create an extension of the online assignment type cp -r mod/assignment/type/online mod/assignment/type/onlinetest Edit mod/assignment/type/onlinetest/version.php changing plugin->component to 'assignment_onlinetest' Edit mod/assignment/type/onlinetest/assignment.class.php changing the classes names to 'assignment_onlinetest' and 'mod_assignment_onlinetest_edit_form', and the call to 'mod_assignment_online_edit_form' to 'mod_assignment_onlinetest_edit_form' Click notifications to install the plugin Create a new onlinetest assignment, there will be missing text strings, it's a test Login as a student and add a submission As a teacher / admin, go to the assignment and click "View N submitted assignments" you SHOULD see the "Download all assignments" link

Description

Skodak has point out it in the code with a TODO comment:

if ($hassubmission && ($this->assignment->assignmenttype=='upload' || $this->assignment->assignmenttype=='online' || $this->assignment->assignmenttype=='uploadsingle')) { //TODO: this is an ugly hack, where is the plugin spirit? (skodak)

I'm making a new assignment type and meet this bug. So I made this patch

Attachments

Activity

People

Assignee:: David Monllaó

Reporter:: Sunner Sun

Peer reviewer:: Rajesh Taneja

Integrator:: Sam Hemelryk

Tester:: Tim Barker

Participants:: Dan Poltawski, David Monllaó, Michael de Raadt, Rajesh Taneja, Sam Hemelryk, Sunner Sun, Tim Barker

Component watchers:: Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 1 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 03/Jul/11 2:53 AM

Updated:: 19/Jul/12 10:43 PM

Resolved:: 19/Jul/12 10:43 PM

Fix Release Date:: 10/Sep/12