Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28160

Why does the Preview question popup window is made to retain the whole course interface?

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.1, 2.2
    • 2.1.1
    • Questions
    • None
    • MOODLE_21_STABLE, MOODLE_22_STABLE
    • MOODLE_21_STABLE
    • Hide

      1.- From Course front page, Navigation block -> Question bank -> Click on the Preview question icon of any question in the bank:
      Preview question popup window is correctly displayed (without any extra elements).

      2.- From Course front page, Navigation block -> Click link to existing Quiz instance (or in central column, click on link to existing Quiz instance)
      When Quiz -> Info page is displayed, in Navigation block -> Question bank -> Click on the Preview question icon of any question in the bank:
      Preview question popup window is incorrectly displayed (with extra elements).

      Show
      1.- From Course front page, Navigation block -> Question bank -> Click on the Preview question icon of any question in the bank: Preview question popup window is correctly displayed (without any extra elements). 2.- From Course front page, Navigation block -> Click link to existing Quiz instance (or in central column, click on link to existing Quiz instance) When Quiz -> Info page is displayed, in Navigation block -> Question bank -> Click on the Preview question icon of any question in the bank: Preview question popup window is incorrectly displayed (with extra elements).

    Description

      running Moodle 2.1 (Build: 20110701)

      In Moodle 2.0, the Preview question popup window contains only the question interface.
      In Moodle 2.1, this has changed and the Preview question popup window contains the site breadcrumb and the navigation block as well, which IMHO is quite useless and obtrusive in this context.
      This is related to file lib/questionlib.php, function question_preview_url(),
      if ($context->contextlevel == CONTEXT_MODULE)

      { $params['cmid'] = $context->instanceid; }

      else if ($context->contextlevel == CONTEXT_COURSE)

      { $params['courseid'] = $context->instanceid; }

      I do not understand the need for these conditions, and would really prefer
      $params['courseid'] = $context->instanceid;
      at all times...

      Attachments

        Issue Links

          has a non-specific relationship to

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-28074 Question preview does not set $PAGE->course, and so does not set forced language

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              timhunt Tim Hunt
              rezeau Joseph Rézeau
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Rossiani Wijaya Rossiani Wijaya
              Safat Shahin, Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                1/Aug/11