Moodle
  1. Moodle
  2. MDL-29160 META: en language pack improvements
  3. MDL-28176

Rephrase "Enable conditional access" (enableavailability) description

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Language
    • Labels:
    • Rank:
      17791

      Description

      The description for "Enable conditional access" currently says:
      "When enabled, this lets you set conditions (based on date, grade, or completion) that control whether an activity can be accessed."

      This suggests that conditional access is available for activities but not necessarily for resources. I would suggest to change the text and mention resources as well. I don't think we have a noun that would cover both "activity" and "resource", so the text could simply be:
      "When enabled, this lets you set conditions (based on date, grade, or completion) that control whether an activity/resource can be accessed."

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this.

        I've put it on our backlog and we'll try to get to it as soon as we can.

        Show
        Michael de Raadt added a comment - Thanks for reporting this. I've put it on our backlog and we'll try to get to it as soon as we can.
        Hide
        Dan Poltawski added a comment -

        Hi Helen,

        I was wondering what you thought on this issue?

        Show
        Dan Poltawski added a comment - Hi Helen, I was wondering what you thought on this issue?
        Hide
        Helen Foster added a comment -

        Hi Dan,

        I agree with Tomasz that language string could be improved by mentioning resources, though I'd suggest the following wording as slightly easier to understand:

        When enabled, this lets you set conditions (based on date, grade, or completion) that control whether an activity or resource can be accessed.

        I don't know why the issue was labeled as 'patch' or set as major priority. As it's an en language pack improvement, I'm setting the component as 'Language' and will move it to MDL-29160 together with other language pack improvements.

        Show
        Helen Foster added a comment - Hi Dan, I agree with Tomasz that language string could be improved by mentioning resources, though I'd suggest the following wording as slightly easier to understand: When enabled, this lets you set conditions (based on date, grade, or completion) that control whether an activity or resource can be accessed. I don't know why the issue was labeled as 'patch' or set as major priority. As it's an en language pack improvement, I'm setting the component as 'Language' and will move it to MDL-29160 together with other language pack improvements.
        Hide
        Dan Poltawski added a comment -

        Thanks Helen, submittign that for integration

        Show
        Dan Poltawski added a comment - Thanks Helen, submittign that for integration
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks (21, 22 & master).

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks (21, 22 & master).
        Hide
        Jason Fowler added a comment -

        Looks good

        Show
        Jason Fowler added a comment - Looks good
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This has been near becoming rejected, because it's not the best code you are able to produce.

        But, luckily, at the end, it has landed and has been spread to all repos out there.

        Many thanks and, don't forget it, keep improving your skills, you can!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: