Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28179

Events API does not keep useful information when an event handler throws an exception

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.1.1
    • Component/s: Events API
    • Labels:
      None
    • Testing Instructions:
      Hide

      1. Find (or make) a buggy event hander.
      2. Trigger an event for it to handle.
      3. Look in the events_queue_handlers DB table, and confirm that the stack trace and debuginfo you really need to diagnose the problem is now there.

      Show
      1. Find (or make) a buggy event hander. 2. Trigger an event for it to handle. 3. Look in the events_queue_handlers DB table, and confirm that the stack trace and debuginfo you really need to diagnose the problem is now there.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      I just needed these changes to debug my event handler, so I am assuming that they will be useful for other people too. Therefore, submitting for integration.

        Gliffy Diagrams

          Activity

          Hide
          timhunt Tim Hunt added a comment -

          I effectively tested this while working on MDL-28166.

          Although this is developer interest only, I think it would be nice to add to 2.1 stable as well as master.

          Show
          timhunt Tim Hunt added a comment - I effectively tested this while working on MDL-28166 . Although this is developer interest only, I think it would be nice to add to 2.1 stable as well as master.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Integrated thanks! (21_STABLE and master)

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Integrated thanks! (21_STABLE and master)
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Passing under my entire responsibility based on developer comments of this already having been used already.

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Passing under my entire responsibility based on developer comments of this already having been used already.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          All this cool stuff is now part of Moodle, thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - All this cool stuff is now part of Moodle, thanks!

            People

            • Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7)
              Participants:
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                1/Aug/11