Moodle
  1. Moodle
  2. MDL-28184

Argument 1 passed to global_navigation::add_course_essentials() must be an instance of navigation_node, boolean given

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1
    • Fix Version/s: 2.0.4, 2.1.1
    • Component/s: Navigation
    • Labels:
      None
    • Environment:
      moodle.org
    • Testing Instructions:
      Hide
      1. Browse around your site logged in as an admin and visit at least the front page, a course front page, a module, your user profile, and another users profile.
      2. Check that the navigation doesn't throw errors on any of those pages
      Show
      Browse around your site logged in as an admin and visit at least the front page, a course front page, a module, your user profile, and another users profile. Check that the navigation doesn't throw errors on any of those pages
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:
      wip-MDL-28184-master
    • Rank:
      17798

      Description

      a Bing.com robot was crawling moodle.org and caused the following in the apache error_log

      Default exception handler: Coding error detected, it must be fixed by a programmer: PHP catchable fatal error Debug: Argument 1 passed to global_navigation::add_course_essentials() must be an instance of navigation_node, boolean given, called in /lib/navigationlib.php on line 1173 and defined
      * line 359 of /lib/setuplib.php: coding_exception thrown
      * line 2171 of /lib/navigationlib.php: call to default_error_handler()
      * line 1173 of /lib/navigationlib.php: call to global_navigation->add_course_essentials()
      * line 2571 of /lib/navigationlib.php: call to global_navigation->initialise()
      * line 659 of /lib/pagelib.php: call to navbar->has_items()
      * line 4 of /theme/moodleofficial/layout/general.php: call to moodle_page->has_navbar()
      * line 654 of /lib/outputrenderers.php: call to include()
      * line 612 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
      * line ? of unknownfile: call to core_renderer->header()
      * line 1279 of /lib/setuplib.php: call to call_user_func_array()
      * line 2354 of /lib/weblib.php: call to bootstrap_renderer->__call()
      * line 2354 of /lib/weblib.php: call to bootstrap_renderer->header()
      * line 2495 of /lib/moodlelib.php: call to notice()
      * line 2741 of /lib/moodlelib.php: call to require_login()
      * line 47 of /mod/forum/discuss.php: call to require_course_login()
      

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Up for peer-review

          Show
          Sam Hemelryk added a comment - Up for peer-review
          Hide
          Aparup Banerjee added a comment -

          looking

          Show
          Aparup Banerjee added a comment - looking
          Hide
          Aparup Banerjee added a comment -

          Hi Sam,
          aside from that typo on the commit msg (handline->handling) this looks great to me. i've tested with the pages in test as well as profiles viewed via mentees block. seems fine to me.
          cheers!

          Show
          Aparup Banerjee added a comment - Hi Sam, aside from that typo on the commit msg (handline->handling) this looks great to me. i've tested with the pages in test as well as profiles viewed via mentees block. seems fine to me. cheers!
          Hide
          Sam Hemelryk added a comment -

          Up for integration - thanks for the peer-review Apu

          Show
          Sam Hemelryk added a comment - Up for integration - thanks for the peer-review Apu
          Hide
          Petr Škoda added a comment -

          Integrated, thanks.

          Show
          Petr Škoda added a comment - Integrated, thanks.
          Hide
          Petr Škoda added a comment -

          I went through many pages in all branches today testing other issues, so far it works fine for me. Thanks.

          Show
          Petr Škoda added a comment - I went through many pages in all branches today testing other issues, so far it works fine for me. Thanks.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: