Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28186

"Enable messaging system" advanced feature removes Messaging settings from the user menu.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.1.1
    • Component/s: Messages
    • Labels:
    • Database:
      PostgreSQL
    • Testing Instructions:
      Hide

      1. (Admin) Go to Site administration > Advanced features, ensure that "Enable messaging system" is ticked off (enabled).
      2. (Any user) Open "My profile settings > Messaging". Ensure that "Personal messages between users" preference in listed.
      3. (Admin) Go to Site administration > Advanced features, and untick "Enable messaging system"
      4. (Any user) Go to "My profile settings". "Messaging" menu item should still be listed there.
      5. (Any user) Open "My profile settings > Messaging". Ensure that "Personal messages between users" preference in not listed.

      Show
      1. (Admin) Go to Site administration > Advanced features, ensure that "Enable messaging system" is ticked off (enabled). 2. (Any user) Open "My profile settings > Messaging". Ensure that "Personal messages between users" preference in listed. 3. (Admin) Go to Site administration > Advanced features, and untick "Enable messaging system" 4. (Any user) Go to "My profile settings". "Messaging" menu item should still be listed there. 5. (Any user) Open "My profile settings > Messaging". Ensure that "Personal messages between users" preference in not listed.
    • Workaround:
      Hide

      Though the menu item is missing, user can still access the messaging preferences page directly, e.g. moodle/message/edit.php?id=2&course=1

      Show
      Though the menu item is missing, user can still access the messaging preferences page directly, e.g. moodle/message/edit.php?id=2&course=1
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      "Enable messaging system" (Site administration > Advanced features) is supposed to control messaging between site users only. However, when the setting is disabled, in addition to removal of "My profile > Messages" (which is fine, trying to access this page directly gives an error) it removes "My profile settings > Messaging" which should remain there as it allows user to control many other message types delivery methods (in fact, this page is still accessible if called directly, e.g. moodle/message/edit.php?id=2&course=1, only menu item is removed).

      The solution probably should be along these lines:

      • "My profile settings > Messaging" should not disappear from the menu when "Enable messaging system" is disabled.
      • "Personal messages between users" type should not be listed in "My profile settings > Messaging" preference page when "Enable messaging system" is disabled.

        Gliffy Diagrams

          Activity

          Hide
          poltawski Dan Poltawski added a comment -

          This can be cherry-picked into 21_STABLE also

          Show
          poltawski Dan Poltawski added a comment - This can be cherry-picked into 21_STABLE also
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          andyjdavis Andrew Davis added a comment -

          That sounds like a reasonable solution. It would be nice if users could access /message/index.php with messaging disabled so they could access their previous notifications however that goes beyond the scope of this issue. +1

          Show
          andyjdavis Andrew Davis added a comment - That sounds like a reasonable solution. It would be nice if users could access /message/index.php with messaging disabled so they could access their previous notifications however that goes beyond the scope of this issue. +1
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks! (21_STABLE and master).

          Plz, add testing instrucions, TIA!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (21_STABLE and master). Plz, add testing instrucions, TIA!
          Hide
          kabalin Ruslan Kabalin added a comment -

          Testing instructions are added.

          Show
          kabalin Ruslan Kabalin added a comment - Testing instructions are added.
          Hide
          andyjdavis Andrew Davis added a comment -

          looks good.

          Show
          andyjdavis Andrew Davis added a comment - looks good.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Congratulations - this fix has just been released in the weeklies.

          Show
          samhemelryk Sam Hemelryk added a comment - Congratulations - this fix has just been released in the weeklies.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                1/Aug/11