Moodle
  1. Moodle
  2. MDL-28187

Navigation issue with user messaging preferences page

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Messages
    • Labels:
      None
    • Database:
      PostgreSQL
    • Testing Instructions:
      Hide
      1. Go to 'my home' or 'site home'
      2. Open "My profile settings > Messaging"
      3. Check that the nav breadcrumbs say Home ► My profile settings ► Messaging"
      4. Check that "Messaging" is highlighted in the navigation block
      Show
      Go to 'my home' or 'site home' Open "My profile settings > Messaging" Check that the nav breadcrumbs say Home ► My profile settings ► Messaging" Check that "Messaging" is highlighted in the navigation block
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-28187_messaging_nav
    • Rank:
      17799

      Description

      When "My profile settings > Messaging" page is open, the top navigation menu bar reads "Home ► My profile settings" instead of "Home ► My profile settings ► Messaging". Also corresponding Messaging item is not highlighted in the Settings navigation menu.

        Activity

        Hide
        Michael de Raadt added a comment -

        This issue has been resolved by the linked issue.

        Show
        Michael de Raadt added a comment - This issue has been resolved by the linked issue.
        Hide
        Ruslan Kabalin added a comment -

        Hello Michael, I object, the issue has not been resolved by the linked one. The linked one solved "Enable messaging" and menu item appearance. This issue is about navigation.

        Show
        Ruslan Kabalin added a comment - Hello Michael, I object, the issue has not been resolved by the linked one. The linked one solved "Enable messaging" and menu item appearance. This issue is about navigation.
        Hide
        Ruslan Kabalin added a comment -

        In fact, the linked one should not be linked to this as they are sort of independent.

        Show
        Ruslan Kabalin added a comment - In fact, the linked one should not be linked to this as they are sort of independent.
        Hide
        Andrew Davis added a comment -

        Adding a branch that fixes this. We were just unnecessarily excluding some URL parameters.

        Show
        Andrew Davis added a comment - Adding a branch that fixes this. We were just unnecessarily excluding some URL parameters.
        Hide
        Dan Poltawski added a comment -

        Looks good to me.

        Ruslan, are you able to verify this?

        Show
        Dan Poltawski added a comment - Looks good to me. Ruslan, are you able to verify this?
        Hide
        Ruslan Kabalin added a comment -

        Tested. Works fine and solves the issue. Ready for integration.

        Show
        Ruslan Kabalin added a comment - Tested. Works fine and solves the issue. Ready for integration.
        Hide
        Ruslan Kabalin added a comment -

        Thanks Andrew

        Show
        Ruslan Kabalin added a comment - Thanks Andrew
        Hide
        Andrew Davis added a comment -

        Added branches for 2.2 and 2.1 stable. Putting this up for integration.

        Show
        Andrew Davis added a comment - Added branches for 2.2 and 2.1 stable. Putting this up for integration.
        Hide
        Sam Hemelryk added a comment -

        Thanks Andrew this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Andrew this has been integrated now
        Hide
        Michael de Raadt added a comment -

        Test result: Success. Quickest test ever!

        Tested on 2.1, 2.2 and master.

        Show
        Michael de Raadt added a comment - Test result: Success. Quickest test ever! Tested on 2.1, 2.2 and master.
        Hide
        Sam Hemelryk added a comment -

        Congratulations are in order, you've made it, or at least your code has!
        It's now part of Moodle and both the git and cvs repositories have been updated.

        This issue is being marked as fixed and closed.

        Thank you.

        Show
        Sam Hemelryk added a comment - Congratulations are in order, you've made it, or at least your code has! It's now part of Moodle and both the git and cvs repositories have been updated. This issue is being marked as fixed and closed. Thank you.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: