Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28191

Theme selector: after selecting a theme, continue goes to wrong place

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1.1, 2.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      1. Go to Appearance / Themes / Theme selector
      2. Click 'Select theme' next to 'Default'.
      3. Choose a theme.
      4. If a the theme description displays, with a Continue button, click this button.
      5. Make sure you are takin back to the select theme screen
      SUCCESS = You are returned to the theme selector.
      FAILURE = You are returned to the Notifications page.

      Show
      1. Go to Appearance / Themes / Theme selector 2. Click 'Select theme' next to 'Default'. 3. Choose a theme. 4. If a the theme description displays, with a Continue button, click this button. 5. Make sure you are takin back to the select theme screen SUCCESS = You are returned to the theme selector. FAILURE = You are returned to the Notifications page.
    • Workaround:
      Hide

      Take a chill pill and navigate back to the theme selector every time, or use browser Back button a couple times to get there instead of clicking Continue.

      Show
      Take a chill pill and navigate back to the theme selector every time, or use browser Back button a couple times to get there instead of clicking Continue.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      wip-MDL-28191-master

      Description

      When using the new theme selector in 2.1, the sequence works like this:

      1. Click on 'select default theme' button.
      2. Select a theme.
      3. Annoying message appears with theme description; click Continue.
      4. Swear vociferously at computer as it has taken you back to the admin root page instead of to the theme selector, where you now need to be because you need to select at least two themes (default and tablet, which should basically always be the same).

      I would suggest that on selecting a theme, you should be returned to the page that shows selected themes for each device type. (Ideally straight away, but if there is some purpose to the theme description page, then OK, from the continue button on that.)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                samhemelryk Sam Hemelryk
                Reporter:
                quen Sam Marshall
                Peer reviewer:
                Sam Hemelryk
                Integrator:
                Petr Skoda
                Tester:
                Marina Glancy
                Participants:
                Component watchers:
                Bas Brands, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  1/Aug/11