Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28195

confirm_action should allow the button labels to be customised

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1.1
    • Component/s: Libraries
    • Labels:
      None
    • Testing Instructions:
      Hide

      1. Check a place that currently uses confirm_action. For example clearing all assessments in a workshop. Make sure it sill works.

      2. Once MDL-26165 is integrated, check that the quiz 'are you sure you want to start/submit this attempt' dialogues have customised button labels.

      Show
      1. Check a place that currently uses confirm_action. For example clearing all assessments in a workshop. Make sure it sill works. 2. Once MDL-26165 is integrated, check that the quiz 'are you sure you want to start/submit this attempt' dialogues have customised button labels.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      The confirm_action lib/outputactions.php is hard-coded to use button captions Cancel and Yes. This is not always appropriate. The API should be extended to allow custom labels. (For example, MDL-26165 is hard to fix at the moment.)

        Attachments

          Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MDL-26165 When unlimited retakes of quiz is allowed, confirmation message implies answers can no longer be changed.

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-28284 Filepicker module should be included only where it is needed - not on every page

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-28285 confirm_action should be requiring its own strings in JS or alternatively sending them after making a get_string call

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-28286 Uses of M.str.{component}.{identifier} should be reviewed and converted to M.util.get_string where possible to avoid needless JS errors from missing strings

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-28287 Find a way to require the dock module ONLY when needed

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              • Assignee:
                timhunt Tim Hunt
                Reporter:
                timhunt Tim Hunt
                Peer reviewer:
                Sam Hemelryk
                Integrator:
                Sam Hemelryk
                Tester:
                Rossiani Wijaya
                Participants:
                Component watchers:
                Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  1/Aug/11