Moodle
  1. Moodle
  2. MDL-28196

Quiz code calls get_in_or_equal (not $DB->get_in_or_equal) in two places

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.1.1
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      1. Create a quiz, set to separate groups mode. Attempt it as a few times as a student in one of the groups.
      2. As teacher/admin, go to the Results report, and try to view the results from the student's group.

      Show
      1. Create a quiz, set to separate groups mode. Attempt it as a few times as a student in one of the groups. 2. As teacher/admin, go to the Results report, and try to view the results from the student's group.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      17913

      Description

      I can't believe we did not catch this before.

        Issue Links

          Activity

          Hide
          Tim Hunt added a comment -

          Please cherry-pick onto MOODLE_21_STABLE too.

          Show
          Tim Hunt added a comment - Please cherry-pick onto MOODLE_21_STABLE too.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Side comment, just found one more call to quiz_report_feedback_for_grade() not passing the context, FYI:

          mod/quiz/report/attemptsreport.php => col_feedbacktext() function

          Show
          Eloy Lafuente (stronk7) added a comment - Side comment, just found one more call to quiz_report_feedback_for_grade() not passing the context, FYI: mod/quiz/report/attemptsreport.php => col_feedbacktext() function
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (21_STABLE and master).

          Appart from the quiz_report_feedback_for_grade() use commented above, for your consideration, I've changed one not-used $CFG by one missing $DB, adding one commit to each branch.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (21_STABLE and master). Appart from the quiz_report_feedback_for_grade() use commented above, for your consideration, I've changed one not-used $CFG by one missing $DB, adding one commit to each branch. Ciao
          Hide
          Tim Hunt added a comment -

          Thank you for fixing up my rubbish Eloy. Clearly I only tested one of the bits I changed, not both.

          Show
          Tim Hunt added a comment - Thank you for fixing up my rubbish Eloy. Clearly I only tested one of the bits I changed, not both.
          Hide
          Tim Hunt added a comment -

          MDL-28222 created for the other quiz_report_feedback_for_grade error.

          Show
          Tim Hunt added a comment - MDL-28222 created for the other quiz_report_feedback_for_grade error.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          All this cool stuff is now part of Moodle, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - All this cool stuff is now part of Moodle, thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: