Moodle

Notice on RSS block manage feeds page

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.3, 2.1
  • Fix Version/s: 2.0.4, 2.1.1
  • Component/s: RSS
  • Labels:
  • Testing Instructions:
    Hide

    1. Add an RSS block to a page.
    2. Click the edit icon for the block
    3. On the edit screen click Add/edit feeds
    4. Check you don't see a notice about not settings the base url for the flexi-table
    5. Check you have blocks on the page

    Show
    1. Add an RSS block to a page. 2. Click the edit icon for the block 3. On the edit screen click Add/edit feeds 4. Check you don't see a notice about not settings the base url for the flexi-table 5. Check you have blocks on the page
  • Affected Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    wip-MDL-28205-master
  • Pull Master Diff URL:

Description

Its a notice... whoop-de-do

You should set baseurl when using flexible_table.

line 481 of /lib/tablelib.php: call to debugging()
line 105 of /blocks/rss_client/managefeeds.php: call to flexible_table->setup()

Issue Links

is duplicated by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-28231 warning when viewing manage feeds page

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sam Hemelryk added a comment -

Can I please get a peer-review?

Show
Sam Hemelryk added a comment - Can I please get a peer-review?
Hide
Permalink
Dan Poltawski added a comment -

Hi Sam,

I can't actually reproduce this error!

Show
Dan Poltawski added a comment - Hi Sam, I can't actually reproduce this error!
Hide
Permalink
Dan Poltawski added a comment -

Urm, apologies - yes I can - was on the wrong branch!

Show
Dan Poltawski added a comment - Urm, apologies - yes I can - was on the wrong branch!
Hide
Permalink
Dan Poltawski added a comment -

Looks good, please get this integrated ASAP!

Show
Dan Poltawski added a comment - Looks good, please get this integrated ASAP!
Hide
Permalink
Sam Hemelryk added a comment -

Hi Dan, thanks for looking at that for me, its up for integration now (sorry I must've forgot to submit that comment when I actually put it up the other day).

Cheers
Sam

Show
Sam Hemelryk added a comment - Hi Dan, thanks for looking at that for me, its up for integration now (sorry I must've forgot to submit that comment when I actually put it up the other day). Cheers Sam
Hide
Permalink
Petr Škoda added a comment -

Integrated, thanks.

Show
Petr Škoda added a comment - Integrated, thanks.
Hide
Permalink
Petr Škoda added a comment -

tested, no errors displayed, thanks.

Show
Petr Škoda added a comment - tested, no errors displayed, thanks.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: