Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28205

Notice on RSS block manage feeds page

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1
    • Fix Version/s: 2.0.4, 2.1.1
    • Component/s: RSS
    • Labels:
    • Testing Instructions:
      Hide

      1. Add an RSS block to a page.
      2. Click the edit icon for the block
      3. On the edit screen click Add/edit feeds
      4. Check you don't see a notice about not settings the base url for the flexi-table
      5. Check you have blocks on the page

      Show
      1. Add an RSS block to a page. 2. Click the edit icon for the block 3. On the edit screen click Add/edit feeds 4. Check you don't see a notice about not settings the base url for the flexi-table 5. Check you have blocks on the page
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:
      wip-MDL-28205-master

      Description

      Its a notice... whoop-de-do

      You should set baseurl when using flexible_table.

      line 481 of /lib/tablelib.php: call to debugging()
      line 105 of /blocks/rss_client/managefeeds.php: call to flexible_table->setup()

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            samhemelryk Sam Hemelryk added a comment -

            Can I please get a peer-review?

            Show
            samhemelryk Sam Hemelryk added a comment - Can I please get a peer-review?
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Sam,

            I can't actually reproduce this error!

            Show
            poltawski Dan Poltawski added a comment - Hi Sam, I can't actually reproduce this error!
            Hide
            poltawski Dan Poltawski added a comment -

            Urm, apologies - yes I can - was on the wrong branch!

            Show
            poltawski Dan Poltawski added a comment - Urm, apologies - yes I can - was on the wrong branch!
            Hide
            poltawski Dan Poltawski added a comment -

            Looks good, please get this integrated ASAP!

            Show
            poltawski Dan Poltawski added a comment - Looks good, please get this integrated ASAP!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Dan, thanks for looking at that for me, its up for integration now (sorry I must've forgot to submit that comment when I actually put it up the other day).

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Dan, thanks for looking at that for me, its up for integration now (sorry I must've forgot to submit that comment when I actually put it up the other day). Cheers Sam
            Hide
            skodak Petr Skoda added a comment -

            Integrated, thanks.

            Show
            skodak Petr Skoda added a comment - Integrated, thanks.
            Hide
            skodak Petr Skoda added a comment -

            tested, no errors displayed, thanks.

            Show
            skodak Petr Skoda added a comment - tested, no errors displayed, thanks.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  1/Aug/11