Moodle
  1. Moodle
  2. MDL-28209

update 1.9 branch comments , hardcoded links and @links to point to respective new docs.moodle.org urls.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.9.12
    • Fix Version/s: 1.9.14
    • Component/s: General
    • Labels:

      Description

      this was leftover from MDL-28135.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Aparup Banerjee added a comment -

            1.9 branch for changes to static doc links.
            (2.x was done in MDL-28135 - there is also a tiny test script described there)

            Show
            Aparup Banerjee added a comment - 1.9 branch for changes to static doc links. (2.x was done in MDL-28135 - there is also a tiny test script described there)
            Hide
            Andrew Davis added a comment - - edited

            Hi. If I search your branch for "docs.moodle.org/en" I still come up with 27 matches.

            25 of them are links to http://docs.moodle.org/en/Installing_Postgres_for_PHP in various /install/lang files

            The other two are in /admin/index.php

            $copyrighttext = '<a href="http://moodle.org/">Moodle</a> '.
                                 '<a href="http://docs.moodle.org/dev/Releases" title="'.$CFG->version.'">'.$CFG->release.'</a><br />'.
                                 'Copyright &copy; 1999 onwards, Martin Dougiamas<br />'.
                                 'and <a href="http://docs.moodle.org/en/Credits">many other contributors</a>.<br />'.
                                 '<a href="http://docs.moodle.org/en/License">GNU Public License</a>';
            

            Show
            Andrew Davis added a comment - - edited Hi. If I search your branch for "docs.moodle.org/en" I still come up with 27 matches. 25 of them are links to http://docs.moodle.org/en/Installing_Postgres_for_PHP in various /install/lang files The other two are in /admin/index.php $copyrighttext = '<a href="http://moodle.org/">Moodle</a> '. '<a href="http://docs.moodle.org/dev/Releases" title="'.$CFG->version.'">'.$CFG->release.'</a><br />'. 'Copyright &copy; 1999 onwards, Martin Dougiamas<br />'. 'and <a href="http://docs.moodle.org/en/Credits">many other contributors</a>.<br />'. '<a href="http://docs.moodle.org/en/License">GNU Public License</a>';
            Hide
            Aparup Banerjee added a comment -

            the lang files - i should've noted that AMOS needs to update those links... adding David as watcher.
            the admin/index.php is in line with 2.x branches.. do we have different license versions?

            Show
            Aparup Banerjee added a comment - the lang files - i should've noted that AMOS needs to update those links... adding David as watcher. the admin/index.php is in line with 2.x branches.. do we have different license versions?
            Hide
            Aparup Banerjee added a comment -

            David, AMOS needs to update the lang files for 1.9.x

            Show
            Aparup Banerjee added a comment - David, AMOS needs to update the lang files for 1.9.x
            Hide
            David Mudrak added a comment -

            No. This is not AMOS issue.

            1) Those links from /install/lang/ are part of the translation and must be fixed by language pack maintaners. You can use the Languages forum at moodle.org to publish the list of strings that need update.
            2) AMOS does not touch 1.9 branches at all. The /install/lang/*_utf8/ files are generated by a legacy script from CVS moodle-lang repository

            Show
            David Mudrak added a comment - No. This is not AMOS issue. 1) Those links from /install/lang/ are part of the translation and must be fixed by language pack maintaners. You can use the Languages forum at moodle.org to publish the list of strings that need update. 2) AMOS does not touch 1.9 branches at all. The /install/lang/*_utf8/ files are generated by a legacy script from CVS moodle-lang repository
            Hide
            Aparup Banerjee added a comment - - edited

            Thanks all.
            so then this patch should be good to go.

            I'll create a post for lang files modifications (in http://moodle.org/mod/forum/view.php?id=43) once i have the strings that need changing.
            posted @http://moodle.org/mod/forum/view.php?id=43

            Show
            Aparup Banerjee added a comment - - edited Thanks all. so then this patch should be good to go. I'll create a post for lang files modifications (in http://moodle.org/mod/forum/view.php?id=43 ) once i have the strings that need changing. posted @ http://moodle.org/mod/forum/view.php?id=43
            Hide
            Petr Skoda added a comment -

            Ohlala, this should have been done BEFORE the today's release!

            Show
            Petr Skoda added a comment - Ohlala, this should have been done BEFORE the today's release!
            Hide
            Petr Skoda added a comment -

            Next time we should decide a lot earlier when the 1.9.x gets released and communicate it with all devs at least two weeks in advance.

            Show
            Petr Skoda added a comment - Next time we should decide a lot earlier when the 1.9.x gets released and communicate it with all devs at least two weeks in advance.
            Hide
            Sam Hemelryk added a comment -

            Thanks Apu, this has been integrated now.
            In regards to the two remaining strings in admin/index.php I certainly think we need to consolidate that information to one wiki (likely dev) and then update those strings. Perhaps best to talk to Martin about that.

            Cheers
            Sam

            Show
            Sam Hemelryk added a comment - Thanks Apu, this has been integrated now. In regards to the two remaining strings in admin/index.php I certainly think we need to consolidate that information to one wiki (likely dev) and then update those strings. Perhaps best to talk to Martin about that. Cheers Sam
            Hide
            Koen Roggemans added a comment -

            The link (docs.moodle.org/en/Installing_Postgres_for_PHP) is at the moment also wrong in the English master language pack.
            I'll look at the language packs where there is no translator with CVS access if there are any.

            Show
            Koen Roggemans added a comment - The link (docs.moodle.org/en/Installing_Postgres_for_PHP) is at the moment also wrong in the English master language pack. I'll look at the language packs where there is no translator with CVS access if there are any.
            Hide
            Andrew Davis added a comment -

            I tried a random assortment of links to docs and they all seem sensible.

            I didn't bother with your script because, as you wrote it, I presume you ran it and that you fixed any problems your script found. Using your script to test your work would essentially be me taking your word that its fixed

            Show
            Andrew Davis added a comment - I tried a random assortment of links to docs and they all seem sensible. I didn't bother with your script because, as you wrote it, I presume you ran it and that you fixed any problems your script found. Using your script to test your work would essentially be me taking your word that its fixed
            Hide
            Aparup Banerjee added a comment -

            Thanks for testing. Thats very presumptuous of you

            Show
            Aparup Banerjee added a comment - Thanks for testing. Thats very presumptuous of you

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: