Moodle
  1. Moodle
  2. MDL-28218

admin/webservice/testclient.php does not work correctly with services defined in plugins

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1
    • Fix Version/s: 2.0.4, 2.1.1
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide

      1. Get any plugin that defines a web-service, and which has a 'testclientpath' => '...', line in its services.php file.
      2. Install that plugin, and go to the web services test client in the admin menu.
      3. Verify that the service shows up in the dropdown menu of available services.

      Show
      1. Get any plugin that defines a web-service, and which has a 'testclientpath' => '...', line in its services.php file. 2. Install that plugin, and go to the web services test client in the admin menu. 3. Verify that the service shows up in the dropdown menu of available services.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      17943

      Description

      It expects external_function_info to load the external_function_info function to return the ->testclientpath from the services.php file, but it doesn't.

        Activity

        Hide
        Tim Hunt added a comment -

        Jerome, please could you review this when you get a moment. If it is OK, please could you cherry-pick to fixes onto the 2.0 and 2.1 stable branches, and submit it for integration. Thanks.

        Show
        Tim Hunt added a comment - Jerome, please could you review this when you get a moment. If it is OK, please could you cherry-pick to fixes onto the 2.0 and 2.1 stable branches, and submit it for integration. Thanks.
        Hide
        Michael de Raadt added a comment -

        Hi, Tim.

        Jerome is on holidays until next week. (In fact, he's right around the corner from you in France. Perhaps you could tell him in person. )

        Although, in saying that, he is checking some things while he is away.

        Michael;

        Show
        Michael de Raadt added a comment - Hi, Tim. Jerome is on holidays until next week. (In fact, he's right around the corner from you in France. Perhaps you could tell him in person. ) Although, in saying that, he is checking some things while he is away. Michael;
        Hide
        Jérôme Mouneyrac added a comment -

        Thanks Tim. I didn't remember the function description was returned with a tesclintpath key, I need to look more, even though I'm guessing it's good. I'll check when I come back. I'm in New York enjoying broadway shows for three more days then leading for Singapore then Sydney. I'll check into git keeping your credit for 2.0 too.

        Thanks for the fix again

        – Sent from my iPad.

        Show
        Jérôme Mouneyrac added a comment - Thanks Tim. I didn't remember the function description was returned with a tesclintpath key, I need to look more, even though I'm guessing it's good. I'll check when I come back. I'm in New York enjoying broadway shows for three more days then leading for Singapore then Sydney. I'll check into git keeping your credit for 2.0 too. Thanks for the fix again – Sent from my iPad.
        Hide
        Tim Hunt added a comment -

        Ping.

        Jerome, I think this is a simple and safe change that you could easily submit for integration next week.

        Show
        Tim Hunt added a comment - Ping. Jerome, I think this is a simple and safe change that you could easily submit for integration next week.
        Hide
        Jérôme Mouneyrac added a comment -

        It seems goo to me.

        Show
        Jérôme Mouneyrac added a comment - It seems goo to me.
        Hide
        Jérôme Mouneyrac added a comment -

        thanks Tim.

        Show
        Jérôme Mouneyrac added a comment - thanks Tim.
        Hide
        Petr Škoda added a comment -

        Integrated, thanks.

        Show
        Petr Škoda added a comment - Integrated, thanks.
        Hide
        Petr Škoda added a comment -

        oh, integrated into MOODLE_20_SATBLE and MOODLE_21_STABLE too.

        Show
        Petr Škoda added a comment - oh, integrated into MOODLE_20_SATBLE and MOODLE_21_STABLE too.
        Hide
        Rajesh Taneja added a comment -

        Patch works Great
        Thanks for providing the fix Tim.

        Show
        Rajesh Taneja added a comment - Patch works Great Thanks for providing the fix Tim.
        Hide
        Petr Škoda added a comment -

        Thanks everybody, this is now part of the weekly build.

        Show
        Petr Škoda added a comment - Thanks everybody, this is now part of the weekly build.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: