[MDL-28226] LASTATTEMPT quiz not using latest attempt to grade - Moodle Tracker

Details

Testing Instructions:

Hide

Testing is most needed in 2.0:

1. Create a quiz set to grading method first, or last, attempt.
2. Do lots of attempts as one student.
3. Try to persuade your database to return records in an arbitrary order. I think Postgres does this after you have deleted enough rows from a table and vacuummed.
4. Regrade the quiz, and make sure the final grade is computed correctly.

Show
Testing is most needed in 2.0: 1. Create a quiz set to grading method first, or last, attempt. 2. Do lots of attempts as one student. 3. Try to persuade your database to return records in an arbitrary order. I think Postgres does this after you have deleted enough rows from a table and vacuummed. 4. Regrade the quiz, and make sure the final grade is computed correctly.
Affected Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
Fixed Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-28226~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-28226

The quiz grade calculation in LASTATTEMPT mode uses the last on the list of attempts it is given, not the last by data.

This is resolved by checking the attempt is newer than the best so far, so latest attempts are used regardless of order.

Patch incoming with github link

is blocked by

MDL-28227 Regrade sometimes grades user attempts for any quiz not selected quiz

	Duration	recent elements within time bar
		small	large
first row	weekly
	monthy
	quarterly
	yearly
second row	daily
	weekly
	monthy
	quarterly