Moodle
  1. Moodle
  2. MDL-28228

Typo in constant name results in a PHP error (E_NOTICE level)

    Details

    • Testing Instructions:
      Hide

      1/ Upload the following file:

      <?php
       
      require_once('config.php');
       
      $CFG->debug = 0;
       
      $ignore = $PAGE->legacythemeinuse;

      2/ Run the file

      Expected Result:
      no output

      Actual Result - a notce and debug notice is displayed

      Show
      1/ Upload the following file: <?php   require_once('config.php');   $CFG->debug = 0;   $ignore = $PAGE->legacythemeinuse; 2/ Run the file Expected Result: no output Actual Result - a notce and debug notice is displayed
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_22_STABLE
    • Pull from Repository:

      Description

      Line 547 of lib/pagelib.php refers to DEVELOPER_DEBUG (which is undefined) instead of DEBUG_DEVELOPER.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Michael de Raadt added a comment - - edited

            Thanks for spotting that. I checked and can confirm this error.

            Show
            Michael de Raadt added a comment - - edited Thanks for spotting that. I checked and can confirm this error.
            Hide
            Dan Poltawski added a comment -

            Hi Paul,

            Thanks for reporting this, i've submitted the fix for integration.

            Integrators: This can be cherry-picked into master

            Show
            Dan Poltawski added a comment - Hi Paul, Thanks for reporting this, i've submitted the fix for integration. Integrators: This can be cherry-picked into master
            Hide
            Sam Hemelryk added a comment -

            Thanks guys, this has been integrated now. 21, and master.

            Show
            Sam Hemelryk added a comment - Thanks guys, this has been integrated now. 21, and master.
            Hide
            Andrew Davis added a comment -

            Works as described.

            Show
            Andrew Davis added a comment - Works as described.
            Hide
            Petr Skoda added a comment -

            Thanks everybody, this is now part of the weekly build.

            Show
            Petr Skoda added a comment - Thanks everybody, this is now part of the weekly build.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: