Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28228

Typo in constant name results in a PHP error (E_NOTICE level)

    Details

    • Testing Instructions:
      Hide

      1/ Upload the following file:

      <?php
       
      require_once('config.php');
       
      $CFG->debug = 0;
       
      $ignore = $PAGE->legacythemeinuse;

      2/ Run the file

      Expected Result:
      no output

      Actual Result - a notce and debug notice is displayed

      Show
      1/ Upload the following file: <?php   require_once('config.php');   $CFG->debug = 0;   $ignore = $PAGE->legacythemeinuse; 2/ Run the file Expected Result: no output Actual Result - a notce and debug notice is displayed
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_22_STABLE
    • Pull from Repository:

      Description

      Line 547 of lib/pagelib.php refers to DEVELOPER_DEBUG (which is undefined) instead of DEBUG_DEVELOPER.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              salvetore Michael de Raadt added a comment - - edited

              Thanks for spotting that. I checked and can confirm this error.

              Show
              salvetore Michael de Raadt added a comment - - edited Thanks for spotting that. I checked and can confirm this error.
              Hide
              poltawski Dan Poltawski added a comment -

              Hi Paul,

              Thanks for reporting this, i've submitted the fix for integration.

              Integrators: This can be cherry-picked into master

              Show
              poltawski Dan Poltawski added a comment - Hi Paul, Thanks for reporting this, i've submitted the fix for integration. Integrators: This can be cherry-picked into master
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks guys, this has been integrated now. 21, and master.

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks guys, this has been integrated now. 21, and master.
              Hide
              andyjdavis Andrew Davis added a comment -

              Works as described.

              Show
              andyjdavis Andrew Davis added a comment - Works as described.
              Hide
              skodak Petr Skoda added a comment -

              Thanks everybody, this is now part of the weekly build.

              Show
              skodak Petr Skoda added a comment - Thanks everybody, this is now part of the weekly build.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    1/Aug/11