Moodle
  1. Moodle
  2. MDL-28232

Course log text export is missing a new line

        Details

        • Database:
          Any
        • Testing Instructions:
          Hide

          1/ Go to a course
          2/ Click reports -> logs
          3/ Generate a report which returns data and select the 'download in text format' export option from report

          Expected result:
          All log items on seperate lines after the header

          Actual Result:
          First log item on same line as the header

          Show
          1/ Go to a course 2/ Click reports -> logs 3/ Generate a report which returns data and select the 'download in text format' export option from report Expected result: All log items on seperate lines after the header Actual Result: First log item on same line as the header
        • Affected Branches:
          MOODLE_21_STABLE
        • Fixed Branches:
          MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_21_STABLE
        • Pull from Repository:
        • Rank:
          17851

          Description

          Go to course reports > logs and export a log in text format. You'll see something like the below. The first row of data has been concatenated directly onto the column headers.

          Saved at:7 July 2011, 03:38 PM
Course	Time	IP address	User full name	Action	Informationt1	7 July 2011, 03:38 PM	192.168.100.24	Admin User	course report log	test course 
t1	7 July 2011, 03:37 PM	192.168.100.24	Admin User	course report log	test course 
t1	7 July 2011, 03:37 PM	192.168.100.24	Admin User	course report log	test course 
t1	7 July 2011, 03:37 PM	192.168.100.24	Admin User	course view	test course 
t1	7 July 2011, 03:05 PM	192.168.100.24	Admin User	quiz report	test quiz 
t1	7 July 2011, 03:05 PM	192.168.100.24	Admin User	quiz report	test quiz

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Dan Poltawski added a comment -

            Integrators: This patch can be cherry picked into 20_STABLE & master also.

            (I'm not so sure that the 'saved at:' line is good also, but its been there since 2006)

            Show
            Dan Poltawski added a comment - Integrators: This patch can be cherry picked into 20_STABLE & master also. (I'm not so sure that the 'saved at:' line is good also, but its been there since 2006)
            Hide
            Permalink
            Sam Hemelryk added a comment -

            Thanks Dan, this has been integrated now.
            I've cherry-picked it onto 19, 20, and master as well (all were affected in the same way).
            Cheer
            Sam

            Show
            Sam Hemelryk added a comment - Thanks Dan, this has been integrated now. I've cherry-picked it onto 19, 20, and master as well (all were affected in the same way). Cheer Sam
            Hide
            Permalink
            Andrew Davis added a comment -

            Now works as expected. Thanks for the fix

            Show
            Andrew Davis added a comment - Now works as expected. Thanks for the fix
            Hide
            Permalink
            Petr Škoda added a comment -

            Thanks everybody, this is now part of the weekly build.

            Show
            Petr Škoda added a comment - Thanks everybody, this is now part of the weekly build.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: