Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28250

Incorrect link to Creative Commons

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1, 2.2.4, 2.3.1, 2.3.7, 2.4.4, 2.5
    • Fix Version/s: 2.3.8, 2.4.5, 2.5.1
    • Component/s: Licensing
    • Labels:
    • Environment:
      All
    • Database:
      Any
    • Testing Instructions:
      Hide

      Repeat these steps with both upgrade and new installs.

      1. Go to Admin > Plugins > Licences > Manage licences
      2. Verify that Creative Commons - No Commercial is there,
      3. Click on the Creative Commons - No Commercial
      4. VERIFY: that the link goes to the Creative Commons - No Commercial license and NOT Createive Commons - No
      Show
      Repeat these steps with both upgrade and new installs. Go to Admin > Plugins > Licences > Manage licences Verify that Creative Commons - No Commercial is there, Click on the Creative Commons - No Commercial VERIFY: that the link goes to the Creative Commons - No Commercial license and NOT Createive Commons - No
    • URL:
      n/a
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull Master Branch:

      Description

      Settings > Site Administration > Plugins > Licences > Manage licences

      The "Creative Commons - No Commercial" link is pointing to:
      http://creativecommons.org/licenses/by-nd/3.0/
      (Which is in fact Creative Commons - NoDerivs)
      It should be pointing to:
      http://creativecommons.org/licenses/by-nc/3.0/

        Gliffy Diagrams

          Activity

          Hide
          salvetore Michael de Raadt added a comment -

          Thanks for reporting this.

          I've put it on our backlog and we'll try to get to it as soon as we can.

          Show
          salvetore Michael de Raadt added a comment - Thanks for reporting this. I've put it on our backlog and we'll try to get to it as soon as we can.
          Hide
          poltawski Dan Poltawski added a comment -

          Hmm, I had a look at this and although these licenses look like plugins, it seems they don't use the proper plugin architecture and don't upgrade

          Show
          poltawski Dan Poltawski added a comment - Hmm, I had a look at this and although these licenses look like plugins, it seems they don't use the proper plugin architecture and don't upgrade
          Hide
          jimt2 Jim Tittsler added a comment -

          This bug also affects version 2.3.1.

          Show
          jimt2 Jim Tittsler added a comment - This bug also affects version 2.3.1.
          Hide
          galinho Wojciech Galiszek added a comment -

          Since licences are not implemented as a full plugin and they can not be
          upgraded, this bug is actually impossible to fix at the moment. A fix for the new installations for master branch is on github here:
          https://github.com/tmuras/moodle/compare/master...MDL-28250

          Show
          galinho Wojciech Galiszek added a comment - Since licences are not implemented as a full plugin and they can not be upgraded, this bug is actually impossible to fix at the moment. A fix for the new installations for master branch is on github here: https://github.com/tmuras/moodle/compare/master...MDL-28250
          Hide
          poltawski Dan Poltawski added a comment -

          Thanks for your patch Wojciech. Since this issue has been hanging around for a long time, i'm going to fix it by doing a manual query to update the existing license url on sites..

          Show
          poltawski Dan Poltawski added a comment - Thanks for your patch Wojciech. Since this issue has been hanging around for a long time, i'm going to fix it by doing a manual query to update the existing license url on sites..
          Hide
          poltawski Dan Poltawski added a comment -

          Sending this for integration.

          As commented, I'm manually updating the license in SQL as making the plugin system do this is beyond the scope of this issue (and is one of reasons its taken so long).

          I've kept the license version numbers the same across branches. I'd discourage this for a proper plugins as it could create skipped upgrade steps, but I think it is OK for this.

          Show
          poltawski Dan Poltawski added a comment - Sending this for integration. As commented, I'm manually updating the license in SQL as making the plugin system do this is beyond the scope of this issue (and is one of reasons its taken so long). I've kept the license version numbers the same across branches. I'd discourage this for a proper plugins as it could create skipped upgrade steps, but I think it is OK for this.
          Hide
          damyon Damyon Wiese added a comment -

          Thanks Wojciech and Dan for getting this ready.

          Integrated to 23, 24, 25 and master.

          The upgrade looks fine to me - they are not really plugins anyway.

          Show
          damyon Damyon Wiese added a comment - Thanks Wojciech and Dan for getting this ready. Integrated to 23, 24, 25 and master. The upgrade looks fine to me - they are not really plugins anyway.
          Hide
          rwijaya Rossiani Wijaya added a comment -

          This is working as expected.

          Tested for 2.3, 2.4, 2.5 and master.

          Test passed.

          Show
          rwijaya Rossiani Wijaya added a comment - This is working as expected. Tested for 2.3, 2.4, 2.5 and master. Test passed.
          Hide
          damyon Damyon Wiese added a comment -

          Thanks for your contribution! This issue has been reviewed, integrated, tested and now released to everyone.

          Closing as Fixed!

          Show
          damyon Damyon Wiese added a comment - Thanks for your contribution! This issue has been reviewed, integrated, tested and now released to everyone. Closing as Fixed!

            People

            • Votes:
              4 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Jul/13