Moodle
  1. Moodle
  2. MDL-28268

missing ORDER BY clause for the SQL for fetching answer records when answers are joined with the extra answer fields table.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.1.1
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      This only affects third-party question types, and the OU has been encountering this issue, and this patch fixes it. Therefore, no testing required in Moodle core.

      Show
      This only affects third-party question types, and the OU has been encountering this issue, and this patch fixes it. Therefore, no testing required in Moodle core.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      18006

      Activity

      Hide
      Tim Hunt added a comment -

      I just did a quick amend of Jamie's commit (https://github.com/jamiepratt/moodle/compare/moodle...OU-921) to fix the commit comment.

      Jamie, in general, I prefer it if people submit quiz and question issues to me for Peer review, before submitting them for integration. I know I am meant to be on holiday for the next 10 days, and you might not want to wait. I don't know what to suggest in that case ...

      Anyway, thanks for fixing this.

      Show
      Tim Hunt added a comment - I just did a quick amend of Jamie's commit ( https://github.com/jamiepratt/moodle/compare/moodle...OU-921 ) to fix the commit comment. Jamie, in general, I prefer it if people submit quiz and question issues to me for Peer review, before submitting them for integration. I know I am meant to be on holiday for the next 10 days, and you might not want to wait. I don't know what to suggest in that case ... Anyway, thanks for fixing this.
      Hide
      Tim Hunt added a comment -

      I should add:

      Dear integrators, please apply this fix to 21_STABLE and master.

      Show
      Tim Hunt added a comment - I should add: Dear integrators, please apply this fix to 21_STABLE and master.
      Hide
      Jamie Pratt added a comment -

      Sorry Tim. I need to find the document explaining the process for submitting patches for consideration, I had expected that you would review this and didn't mean to bypass you.

      Show
      Jamie Pratt added a comment - Sorry Tim. I need to find the document explaining the process for submitting patches for consideration, I had expected that you would review this and didn't mean to bypass you.
      Hide
      Sam Hemelryk added a comment -

      Thanks guys, this has been integrated now.
      It has been merged to master and cherry-picked to 21_STABLE.
      Please in the future create a branch for each version you want to fix.

      Cheers
      Sam

      Show
      Sam Hemelryk added a comment - Thanks guys, this has been integrated now. It has been merged to master and cherry-picked to 21_STABLE. Please in the future create a branch for each version you want to fix. Cheers Sam
      Hide
      Rajesh Taneja added a comment -

      Passing this test, as suggested in testing instruction "No test required on Moodle Core".
      Thanks for providing the patch Jamie

      Show
      Rajesh Taneja added a comment - Passing this test, as suggested in testing instruction "No test required on Moodle Core". Thanks for providing the patch Jamie
      Hide
      Sam Hemelryk added a comment -

      Congratulations - this fix has just been released in the weeklies.

      Show
      Sam Hemelryk added a comment - Congratulations - this fix has just been released in the weeklies.

        People

        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: