Moodle
  1. Moodle
  2. MDL-2828

Recent activity seems to be broken under PHP 5

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.4
    • Fix Version/s: None
    • Component/s: Course
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_14_STABLE

      Description

      If you take a look to any course/recent.php page with PHP5, every item seems to be repeated n times (for example, in a forum with 3 posts, I see the same post three times).

      Some new Object need to be created in xxxxxx_get_recent_mod_activity() iterations to avoid this effect under PHP5.

      It's the same cause than MDL-2073 (and the same solution should be applied to every xxxxxx_get_recent_mod_activity() function in each module.

      I'll do it (just waiting for your confirmation, Martin).

      Ciao

        Gliffy Diagrams

          Activity

          Hide
          Martin Dougiamas added a comment -

          From Eloy Lafuente (stronk7 at moodle.org) Saturday, 2 April 2005, 07:23 PM:

          Uhm,

          just seeing how the 'new Object;' is working safely in other places since time ago, and because I've to continue with the filterall thing, I'm going to send the patch just now.

          To MOODLE_14_STABLE and HEAD!

          My decision, what responsibility!! :-P

          From Eloy Lafuente (stronk7 at moodle.org) Saturday, 2 April 2005, 07:33 PM:

          Done in 14_STABLE and HEAD! Closing in some hours/days....

          Show
          Martin Dougiamas added a comment - From Eloy Lafuente (stronk7 at moodle.org) Saturday, 2 April 2005, 07:23 PM: Uhm, just seeing how the 'new Object;' is working safely in other places since time ago, and because I've to continue with the filterall thing, I'm going to send the patch just now. To MOODLE_14_STABLE and HEAD! My decision, what responsibility!! :-P From Eloy Lafuente (stronk7 at moodle.org) Saturday, 2 April 2005, 07:33 PM: Done in 14_STABLE and HEAD! Closing in some hours/days....
          Hide
          Michael Blake added a comment -

          assign to a valid user

          Show
          Michael Blake added a comment - assign to a valid user

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: