Moodle
  1. Moodle
  2. MDL-28286

Uses of M.str.{component}.{identifier} should be reviewed and converted to M.util.get_string where possible to avoid needless JS errors from missing strings

    Details

    • Affected Branches:
      MOODLE_21_STABLE
    • Rank:
      17924

      Description

      Just an obvious win - we now have M.util.get_string in javascript-static - it would be nice to use it to avoid any missing string errors.

      Moodle admins - it may be nice to have a couple of new components `JavaScript` and `Page and Output`

      Cheers
      Sam

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Linking to the issue where this issue was first noticed

          Show
          Sam Hemelryk added a comment - Linking to the issue where this issue was first noticed
          Hide
          Andrew Nicols added a comment -

          +1 for this - I came across some in a peer review earlier too. It may be time to start writing JS guidelines which cover these kinds of things, and can be referenced by reviewers.

          Show
          Andrew Nicols added a comment - +1 for this - I came across some in a peer review earlier too. It may be time to start writing JS guidelines which cover these kinds of things, and can be referenced by reviewers.
          Hide
          Andrew Nicols added a comment -

          I'd say it's probably worth only applying this to dev, not stable though.

          Show
          Andrew Nicols added a comment - I'd say it's probably worth only applying this to dev, not stable though.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: