Moodle
  1. Moodle
  2. MDL-28324

bugs in download as Microsoft spreadsheet of Statistics quiz report

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.3
    • Fix Version/s: 2.0.6
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      Try to download a statistics quiz report with third party questions types to see bug 1
      For bug 2 it doesn't "always" happend but I would say "frequently". don't exactly know what is allowed in sheet names in xls documents.

      Show
      Try to download a statistics quiz report with third party questions types to see bug 1 For bug 2 it doesn't "always" happend but I would say "frequently". don't exactly know what is allowed in sheet names in xls documents.
    • Workaround:
      Hide

      for bug 1 replace with return get_string($question->qtype,'qtype_' . $question->qtype);

      for bug2 remove the line

      sorry to not provide something on github to save your time

      Show
      for bug 1 replace with return get_string($question->qtype,'qtype_' . $question->qtype); for bug2 remove the line sorry to not provide something on github to save your time
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull from Repository:

      Description

      2 small bugs in download download as Microsoft spreadsheet of Statistics quiz report
      file mod/quiz/report/statistics/statistics_table.php line 143
      return get_string($question->qtype, 'quiz');
      should be
      return get_string($question->qtype,'qtype_' . $question->qtype);
      file mod/quiz/report/statistics/report.php line 242
      $questiontabletitle = "<em>$questiontabletitle</em>";
      is not good for xls download as this is also used for sheet name in the worksheet and will result in broken .xls documents in most cases with Excel saying the document contain invalid sheet names and needs to be repared

      It seems all is corrected in 2.1

        Gliffy Diagrams

          Activity

          Hide
          Tim Hunt added a comment -

          Thank you for the detailed bug report.

          Show
          Tim Hunt added a comment - Thank you for the detailed bug report.
          Hide
          Tim Hunt added a comment -

          I had forgotten about this, but just found it again, and your suggestions are correct, so I'm submitting the fix for integration now. Thanks Jean-Michel.

          Show
          Tim Hunt added a comment - I had forgotten about this, but just found it again, and your suggestions are correct, so I'm submitting the fix for integration now. Thanks Jean-Michel.
          Hide
          Sam Hemelryk added a comment -

          Thanks Tim - this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Tim - this has been integrated now
          Hide
          Ankit Agarwal added a comment -

          test passed!
          Thanks

          Show
          Ankit Agarwal added a comment - test passed! Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Done, your delicious hacks have been sent upstream, many thanks!

          Closing as fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Done, your delicious hacks have been sent upstream, many thanks! Closing as fixed, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: