Moodle
  1. Moodle
  2. MDL-28337

'Parameters' section in URL resource type needs help and/or is broken

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1
    • Fix Version/s: 2.1.1
    • Component/s: Resource
    • Labels:
      None
    • Rank:
      18220

      Description

      With advanced options on in the settings for a URL type resource there is a section called 'Parameters'. It is unclear what this does or how it is supposed to be used. It makes little or no sense for the specified parameters to have an edit box.

      In addition, whatever I set these to did not make the slightest difference to the generated URL so I don't think it works anyway.

        Activity

        Hide
        Howard Miller added a comment -

        OK... immediately after I wrote this I found http://docs.moodle.org/20/en/File_or_website_link, which explains it. You have to type the parameter name in the text box. This is not even slightly obvious although it would be easily explained with a small line of help text.

        Show
        Howard Miller added a comment - OK... immediately after I wrote this I found http://docs.moodle.org/20/en/File_or_website_link , which explains it. You have to type the parameter name in the text box. This is not even slightly obvious although it would be easily explained with a small line of help text.
        Hide
        Petr Škoda added a comment -

        I think we could change the field label to "&parameter=variable" which might help advanced users to realise what the parameters do.

        We can also add a short description at the beginning of the parameter section. I did not find a place for any help icon, sorry.
        Could you please help me with the wording?

        $string['parameters_help'] = 'Some internal Moodle variables may be automatically appended to the URL. You can type parameter names into text boxes and then select the required variable.';
        Show
        Petr Škoda added a comment - I think we could change the field label to "&parameter=variable" which might help advanced users to realise what the parameters do. We can also add a short description at the beginning of the parameter section. I did not find a place for any help icon, sorry. Could you please help me with the wording? $string['parameters_help'] = 'Some internal Moodle variables may be automatically appended to the URL. You can type parameter names into text boxes and then select the required variable.';
        Hide
        Howard Miller added a comment -

        The thing that threw me was that you could type your own name for the parameter (I assumed it would just use the internal name so I couldn't understand what the edit box was for). I would be a little more forcefull, what about...

        'Some internal Moodle variables may be automatically appended to the URL. Type your name for the parameter into each text box(es) and then select the required matching variable.'

        Show
        Howard Miller added a comment - The thing that threw me was that you could type your own name for the parameter (I assumed it would just use the internal name so I couldn't understand what the edit box was for). I would be a little more forcefull, what about... 'Some internal Moodle variables may be automatically appended to the URL. Type your name for the parameter into each text box(es) and then select the required matching variable.'
        Hide
        Petr Škoda added a comment -

        thanks!

        Show
        Petr Škoda added a comment - thanks!
        Hide
        Sam Hemelryk added a comment -

        Thanks Petr, this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Petr, this has been integrated now
        Hide
        Petr Škoda added a comment -

        Thanks everybody, this is now part of the weekly build.

        Show
        Petr Škoda added a comment - Thanks everybody, this is now part of the weekly build.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: