Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28377

wrong/misplaced or unused parameters when calling the function review_form from review_page (mod_quiz_renderer)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1.1, 2.2
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      This bug did not have much visible effect, however, if you really want to test this:
      1. Go to the review page for one of your own quiz previews ...
      2. with JavaScript disabled ...
      3. and verify that you can update the state of the question flags, and that your changes are saved but the Save flags button.

      Show
      This bug did not have much visible effect, however, if you really want to test this: 1. Go to the review page for one of your own quiz previews ... 2. with JavaScript disabled ... 3. and verify that you can update the state of the question flags, and that your changes are saved but the Save flags button.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      public function review_page(quiz_attempt $attemptobj, $slots, $page, $showall,$lastpage, mod_quiz_display_options $displayoptions,  $summarydata)
      {
      output = '';
      $output .= $this->header();$output .= $this->review_summary_table($summarydata, $page);
      //Here look the order of parameters!!!!!!!
      //first is $page, after $showall .... $showall again?
      $output .= $this->review_form($page, $showall, $displayoptions,$this->questions($attemptobj, true, $slots, $page, $showall, $displayoptions),$attemptobj, $showall);
      $output .= $this->review_next_navigation($attemptobj, $page, $lastpage);
      $output .= $this->footer();
      return $output;
      }
       
      //Look here
      //$page is not first parameter?
      //$summarydata?
      public function review_form($summarydata, $page, $displayoptions, $content, $attemptobj, $showall) 
      	{
              if ($displayoptions->flags != question_display_options::EDITABLE) {
                  return $content;
              }
       
              $this->page->requires->js_init_call('M.mod_quiz.init_review_form', null, false,
                      quiz_get_js_module());
       
              $output = '';
              $output .= html_writer::start_tag('form', array('action' => $attemptobj->review_url(0,
                      $page, $showall), 'method' => 'post', 'class' => 'questionflagsaveform'));
              $output .= html_writer::start_tag('div');
              $output .= $content;
              $output .= html_writer::empty_tag('input', array('type' => 'hidden', 'name' => 'sesskey',
                      'value' => sesskey()));
              $output .= html_writer::start_tag('div', array('class' => 'submitbtns'));
              $output .= html_writer::empty_tag('input', array('type' => 'submit',
                      'class' => 'questionflagsavebutton', 'name' => 'savingflags',
                      'value' => get_string('saveflags', 'question')));
              $output .= html_writer::end_tag('div');
              $output .= html_writer::end_tag('div');
              $output .= html_writer::end_tag('form');
       
              return $output;
          }

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            rafoelhonrado rafael reyna camones
            Integrator:
            Petr Skoda
            Tester:
            Sam Hemelryk
            Participants:
            Component watchers:
            Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              1/Aug/11