Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28443 Action logging improvements META
  3. MDL-28386

Adding a new user creates bad log entry

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.4, 2.2.1, 2.3
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Authentication
    • Labels:
    • Testing Instructions:
      Hide
      1. Login as Admin and add a user by visiting site admin>users>add user
      2. Goto site admin>reports>live reports> live report from past hour
      3. Make sure you see a "user add" row and make sure the links points to the profile of correct user.
      4. Now as admin update an user's profile and visit the report page again.
      5. Make sure you see a "update user" row pointing to correct user profile.
      Show
      Login as Admin and add a user by visiting site admin>users>add user Goto site admin>reports>live reports> live report from past hour Make sure you see a "user add" row and make sure the links points to the profile of correct user. Now as admin update an user's profile and visit the report page again. Make sure you see a "update user" row pointing to correct user profile.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-28386-master

      Description

      When you add a new user using the /user/editadvanced.php page the log entry says the action was "update" not "add" and the url it includes links to a fatal error because the action is logged before the user is created and therefor before the user id is known (which creates a link like "view.php?id=-1&course=1")

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ankit_frenz Ankit Agarwal
              Reporter:
              evanirvingpease Evan Irving-Pease
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              Aparup Banerjee
              Tester:
              Rossiani Wijaya
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Mar/12