Moodle
  1. Moodle
  2. MDL-28397

Activity completion criteria not showing grade requirement

        Details

        • Testing Instructions:
          Hide

          Create new course with completion enabled
          Add the completion status block to the course
          Create new activity in course, set activity completion to be automatic ('show as complete when..') and require a grade. (activity should be gradable eg: assignment)
          Add the activity as a completion criteria via the course admin (completion tracking -> Activites completed)
          Enrol in the course as a learner/student
          Click the "details" link the course completion status block
          The row detailing instructions for completing the activity criteria used to give no indication of what is required.
          Test that you see nothing blank under the 'Requirement'.

          Show
          Create new course with completion enabled Add the completion status block to the course Create new activity in course, set activity completion to be automatic ('show as complete when..') and require a grade. (activity should be gradable eg: assignment) Add the activity as a completion criteria via the course admin (completion tracking -> Activites completed) Enrol in the course as a learner/student Click the "details" link the course completion status block The row detailing instructions for completing the activity criteria used to give no indication of what is required. Test that you see nothing blank under the 'Requirement'.
        • Affected Branches:
          MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
        • Fixed Branches:
          MOODLE_20_STABLE, MOODLE_21_STABLE
        • Pull from Repository:
        • Pull Master Branch:
        • Pull Master Diff URL:

          Description

          When the "Require grade" option is set in the common module settings for an activty, the completion_criteria_activity::get_details() function incorrectly returns a blank requirement.

            Gliffy Diagrams

            1. Text File
              MDL-28397.patch
              0.6 kB
              Evan Irving-Pease

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Sam Marshall added a comment -

              Thanks for patch. This relates to course completion, not activity completion, so reassigning.

              Show
              Sam Marshall added a comment - Thanks for patch. This relates to course completion, not activity completion, so reassigning.
              Hide
              Permalink
              Evan Irving-Pease added a comment -

              The bug is actually in activity completion (completion_criteria_activity.php), it just manifests in a course completion report.

              Show
              Evan Irving-Pease added a comment - The bug is actually in activity completion (completion_criteria_activity.php), it just manifests in a course completion report.
              Hide
              Permalink
              Aaron Barnes added a comment -

              Hi Evan,

              Thank you very much for your patch.

              Cheers,
              Aaron

              Show
              Aaron Barnes added a comment - Hi Evan, Thank you very much for your patch. Cheers, Aaron
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              Integrated, thanks!

              Show
              Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
              Hide
              Permalink
              Aparup Banerjee added a comment -

              Can we please improve the testing instructions? its really difficult to follow through with.

              Show
              Aparup Banerjee added a comment - Can we please improve the testing instructions? its really difficult to follow through with.
              Hide
              Permalink
              Aaron Barnes added a comment -

              How about that?

              Show
              Aaron Barnes added a comment - How about that?
              Hide
              Permalink
              Aparup Banerjee added a comment -

              yes that helped

              Show
              Aparup Banerjee added a comment - yes that helped
              Hide
              Permalink
              Aparup Banerjee added a comment -

              Works for me!

              Show
              Aparup Banerjee added a comment - Works for me!
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

              Show
              Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: