Moodle
  1. Moodle
  2. MDL-28406

Add Block dropdown creates duplicate block if you double click

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1, 2.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Blocks
    • Labels:
    • Rank:
      18060

      Description

      If you add a block to a course or the front page by selecting the block item and double clicking instead of single clicking will create to two instances of the block.

      Replication instructions:

      1. Turn on Editting on Front page or a course.
      2. Select block to add and double click instead of single.
      3. Page refreshes with two of that block

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this. I can confirm this behaviour in Chrome and IE, but not FF.

          There may be other circumstances where duplicate requests are being sent.

          We could resolve this by setting a flag when click event is handled to block future events.

          Show
          Michael de Raadt added a comment - Thanks for reporting this. I can confirm this behaviour in Chrome and IE, but not FF. There may be other circumstances where duplicate requests are being sent. We could resolve this by setting a flag when click event is handled to block future events.
          Hide
          Andrew Davis added a comment -

          Adding master branch details. I will fill out the rest after peer review.

          Show
          Andrew Davis added a comment - Adding master branch details. I will fill out the rest after peer review.
          Hide
          Rajesh Taneja added a comment -

          Looks Good to me

          Show
          Rajesh Taneja added a comment - Looks Good to me
          Hide
          Andrew Davis added a comment -

          Added other branches

          Show
          Andrew Davis added a comment - Added other branches
          Hide
          Sam Hemelryk added a comment -

          Thanks Andrew, this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now.
          Hide
          Aparup Banerjee added a comment - - edited

          seems the patch here has been missed out in MOODLE_21_STABLE - sorry my bad - its there! for some weird reason somehow git fetched it this time!

          anyway this works for me!

          Show
          Aparup Banerjee added a comment - - edited seems the patch here has been missed out in MOODLE_21_STABLE - sorry my bad - its there! for some weird reason somehow git fetched it this time! anyway this works for me!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Sent upstream and closing, many thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Sent upstream and closing, many thanks!

            People

            • Votes:
              3 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: