Moodle
  1. Moodle
  2. MDL-28407

Calendar Preferences can't be saved

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1, 2.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Calendar
    • Labels:

      Description

      When you try and save the Calendar preferences it gets you a course parameter missing error.

      Replication instructions:

      1. Load up calendar
      2. Click on Preferences
      3. Click Save

      A required parameter (course) was missing

      More information about this error

      Stack trace:
      line 429 of /lib/setuplib.php: moodle_exception thrown
      line 468 of /lib/moodlelib.php: call to print_error()
      line 9 of /calendar/preferences.php: call to required_param()

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Tim Lock added a comment -

            Pull Request

            Show
            Tim Lock added a comment - Pull Request
            Hide
            Michael de Raadt added a comment -

            Thanks for reporting this and providing a solution.

            I've put it on our backlog and we'll try to get to it as soon as we can.

            Show
            Michael de Raadt added a comment - Thanks for reporting this and providing a solution. I've put it on our backlog and we'll try to get to it as soon as we can.
            Hide
            Sam Hemelryk added a comment -

            Thanks for spotting this and the initial work Tim.
            In the end I have taken a slightly different approach.
            There was in fact a couple of minor bugs with the form in 2.1 and master which I've fixed up, and I've got around the missing course variable by using the (now corrected) page url as the action.

            Cheers
            Sam

            Show
            Sam Hemelryk added a comment - Thanks for spotting this and the initial work Tim. In the end I have taken a slightly different approach. There was in fact a couple of minor bugs with the form in 2.1 and master which I've fixed up, and I've got around the missing course variable by using the (now corrected) page url as the action. Cheers Sam
            Hide
            Rajesh Taneja added a comment -

            Works Great Sam
            Thanks for working on this.

            Show
            Rajesh Taneja added a comment - Works Great Sam Thanks for working on this.
            Hide
            Brent Lee added a comment -

            I am happy to test this bug when a solution is created. --Brent

            Show
            Brent Lee added a comment - I am happy to test this bug when a solution is created. --Brent
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Note for tester: Plz test both 21_STABLE and 20_STABLE as far as changes are slightly different.

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated, thanks! Note for tester: Plz test both 21_STABLE and 20_STABLE as far as changes are slightly different.
            Hide
            Rossiani Wijaya added a comment -

            Thanks for fixing this Sam.

            Test passed.

            Show
            Rossiani Wijaya added a comment - Thanks for fixing this Sam. Test passed.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Sent upstream and closing, many thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Sent upstream and closing, many thanks!

              People

              • Votes:
                5 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: