Moodle
  1. Moodle
  2. MDL-28411

explain groupings are not groupmembersonly in 1.9

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.12
    • Fix Version/s: 1.9.13
    • Component/s: Administration
    • Labels:
      None
    • Rank:
      18193

      Description

      many people are confused what groupings are, we should improve the experimental setting name and description in 1.9

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Thanks Petr, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Petr, this has been integrated now
          Hide
          Andrew Davis added a comment -

          I don't know about these strings

          "Groupings are a standard feature in later Moodle versions"

          What exactly is a later Moodle version? 1.9? 2.0?

          $string['enablegroupings'] = 'Enable groupings and Available for group members only';
          Should this be the below?
          $string['enablegroupings'] = 'Enable groupings and \'Available for group members only\'';

          Also, if people are confused about what groupings are as is stated in the bug report these changes make no attempt to help with that. It still assumes the user knows what a grouping is.

          Show
          Andrew Davis added a comment - I don't know about these strings "Groupings are a standard feature in later Moodle versions" What exactly is a later Moodle version? 1.9? 2.0? $string ['enablegroupings'] = 'Enable groupings and Available for group members only'; Should this be the below? $string ['enablegroupings'] = 'Enable groupings and \'Available for group members only\''; Also, if people are confused about what groupings are as is stated in the bug report these changes make no attempt to help with that. It still assumes the user knows what a grouping is.
          Hide
          Petr Škoda added a comment -

          The change is that the option says it controls two things.

          What about "Groupings are a standard feature since Moodle 2.0"?

          Show
          Petr Škoda added a comment - The change is that the option says it controls two things. What about "Groupings are a standard feature since Moodle 2.0"?
          Hide
          Petr Škoda added a comment -

          +1 for the quotes too

          Show
          Petr Škoda added a comment - +1 for the quotes too
          Hide
          Sam Hemelryk added a comment -

          How about the following guys:

          $string['configenablegroupings'] = 'This setting enables the creation of groupings as well as the option \'Available for group members only\'. Groupings have been a standard feature since Moodle 2.0. The option \'Available for group members only\' has known problems and is still considered experimental.';
          
          $string['enablegroupings'] = 'Enable groupings and \'Available for group members only\'';
          

          I will also ask Helen's opinion seeing as we have her in the office today!

          Show
          Sam Hemelryk added a comment - How about the following guys: $string['configenablegroupings'] = 'This setting enables the creation of groupings as well as the option \'Available for group members only\'. Groupings have been a standard feature since Moodle 2.0. The option \'Available for group members only\' has known problems and is still considered experimental.'; $string['enablegroupings'] = 'Enable groupings and \'Available for group members only\''; I will also ask Helen's opinion seeing as we have her in the office today!
          Hide
          Andrew Davis added a comment -

          +1

          Show
          Andrew Davis added a comment - +1
          Hide
          Petr Škoda added a comment -

          maybe also ....and is still considered experimental in Moodle 2.0.';

          Show
          Petr Škoda added a comment - maybe also ....and is still considered experimental in Moodle 2.0.';
          Hide
          Helen Foster added a comment -

          My suggestion (approved by Petr via chat) is:

          $string['configenablegroupings'] = 'This setting enables the creation of groupings and the \'Available for group members only\' option. Groupings are a standard feature in Moodle 2.0 onwards whereas \'Available for group members only\' remains an experimental feature.';

          Show
          Helen Foster added a comment - My suggestion (approved by Petr via chat) is: $string ['configenablegroupings'] = 'This setting enables the creation of groupings and the \'Available for group members only\' option. Groupings are a standard feature in Moodle 2.0 onwards whereas \'Available for group members only\' remains an experimental feature.';
          Hide
          Sam Hemelryk added a comment -

          Thanks Helen, I'll make those changes and integrate now then
          Before I do what about the enablegroupings string?

          Show
          Sam Hemelryk added a comment - Thanks Helen, I'll make those changes and integrate now then Before I do what about the enablegroupings string?
          Hide
          Helen Foster added a comment -

          Thanks Sam, I think everyone is fine with:

          $string['enablegroupings'] = 'Enable groupings and \'Available for group members only\'';

          Show
          Helen Foster added a comment - Thanks Sam, I think everyone is fine with: $string ['enablegroupings'] = 'Enable groupings and \'Available for group members only\'';
          Hide
          Sam Hemelryk added a comment -

          Thanks guys those strings have been fixed up now and its up for testing if you could still oblige thanks Andrew.

          Show
          Sam Hemelryk added a comment - Thanks guys those strings have been fixed up now and its up for testing if you could still oblige thanks Andrew.
          Hide
          Andrew Davis added a comment -

          All is now well.

          Show
          Andrew Davis added a comment - All is now well.
          Hide
          Petr Škoda added a comment -

          Thanks everybody, this is now part of the weekly build.

          Show
          Petr Škoda added a comment - Thanks everybody, this is now part of the weekly build.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: