Moodle
  1. Moodle
  2. MDL-28436

IP Restriction not working in the webservices

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.1, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Web Services
    • Labels:
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      see description for replication instructions. you should see ip restrictions displayed and populated with data.

      Show
      see description for replication instructions. you should see ip restrictions displayed and populated with data.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      18082

      Description

      The IP restriction in Moodle 20110713 webservices does not seem to be working. Everytime a new IP is added and the form is saved, the table shown shows the IP field white, with all others filled in.

      Replication instructions:

      1. Go to admin/settings.php?section=webservicetokens
      2. Add new token with IP restriction.

        Issue Links

          Activity

          Hide
          Jozas Nhial added a comment -

          Actually, the IP restriction seems to be in place and stored in the database. However, the table column IP restritction is always blank.

          Show
          Jozas Nhial added a comment - Actually, the IP restriction seems to be in place and stored in the database. However, the table column IP restritction is always blank.
          Hide
          Petr Škoda added a comment -

          Raising priority, thanks for the report.

          Show
          Petr Škoda added a comment - Raising priority, thanks for the report.
          Hide
          Jozas Nhial added a comment -

          I believe this is a duplicate of http://tracker.moodle.org/browse/MDL-26330

          Show
          Jozas Nhial added a comment - I believe this is a duplicate of http://tracker.moodle.org/browse/MDL-26330
          Hide
          Aparup Banerjee added a comment -

          up for peer-review.
          Integrators, feel free to cherry-pick to 2.x stable branches

          Show
          Aparup Banerjee added a comment - up for peer-review. Integrators, feel free to cherry-pick to 2.x stable branches
          Hide
          Jérôme Mouneyrac added a comment -

          Peer-reviewed, it's good to me

          Show
          Jérôme Mouneyrac added a comment - Peer-reviewed, it's good to me
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Aparup Banerjee added a comment -

          ah, rebased.

          Show
          Aparup Banerjee added a comment - ah, rebased.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          (I've lowered prio a bit and taken security out, don't think this was a security issue but an UI glitch only)

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (I've lowered prio a bit and taken security out, don't think this was a security issue but an UI glitch only)
          Hide
          Sam Hemelryk added a comment -

          Tested + passed = thanks

          Show
          Sam Hemelryk added a comment - Tested + passed = thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for all the hard work. This is now part of Moodle, your favorite LMS.

          Closing as fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for all the hard work. This is now part of Moodle, your favorite LMS. Closing as fixed, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: