Moodle
  1. Moodle
  2. MDL-28437

Question bank pages should all use General type: admin

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1
    • Fix Version/s: 2.0.4, 2.1.1, 2.2
    • Component/s: Questions, Themes
    • Labels:
    • Testing Instructions:
      Hide

      1. Turn on 'Show page info' on Admin -> Developer -> Debugging.
      2. Go through all the pages in the question bank, accessed from the course settings and the quiz settings.
      3. Verify that every page is General type: admin, expcept preview, which is General type: popup.

      Show
      1. Turn on 'Show page info' on Admin -> Developer -> Debugging. 2. Go through all the pages in the question bank, accessed from the course settings and the quiz settings. 3. Verify that every page is General type: admin, expcept preview, which is General type: popup.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      18084

      Description

      I think the pages question/edit.php, question/question.php, quetsion/category.php, question/import.php and question/export.php should all do $PAGE->set_pagelayout('admin');

        Issue Links

          Activity

          Hide
          Tim Hunt added a comment -
          Show
          Tim Hunt added a comment - See http://moodle.org/mod/forum/discuss.php?d=181714 for discussion of this.
          Hide
          Petr Škoda added a comment -

          Integrated, thanks.

          Show
          Petr Škoda added a comment - Integrated, thanks.
          Hide
          Marina Glancy added a comment -

          The pages 'group overrides', 'user overrides' still use incourse page type. Also 'backup', but this should probably be fixed not in this issue.

          Show
          Marina Glancy added a comment - The pages 'group overrides', 'user overrides' still use incourse page type. Also 'backup', but this should probably be fixed not in this issue.
          Hide
          Tim Hunt added a comment -

          I created MDL-28469 for the override pages.

          The backup page is generic, common to all activities. I did not create a new issue for that yet. Please can you create one if you think it is important enough.

          Show
          Tim Hunt added a comment - I created MDL-28469 for the override pages. The backup page is generic, common to all activities. I did not create a new issue for that yet. Please can you create one if you think it is important enough.
          Hide
          Petr Škoda added a comment -

          Passing as tested, thanks everybody.

          Show
          Petr Škoda added a comment - Passing as tested, thanks everybody.
          Hide
          Petr Škoda added a comment -

          Thanks everybody, this is now part of the weekly build.

          Show
          Petr Škoda added a comment - Thanks everybody, this is now part of the weekly build.

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: