Moodle
  1. Moodle
  2. MDL-28440

Missing semicolon in yui_module JS code

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3
    • Fix Version/s: 2.0.4, 2.1.1
    • Component/s: Libraries
    • Labels:

      Description

      Missing semicolon when the yui_module function is called and $ondomready is false. This creates big problems if you follow that statement with javascript like this: (function(Y)

      { ...do something... }

      )(Y); Because it then thinks you are trying to call the yui_module code as a function. Attaching patch for the fix.

        Gliffy Diagrams

          Activity

          Hide
          Sam Hemelryk added a comment -

          Thanks guys, this has been integrated now.
          Good spotting Mark!

          Show
          Sam Hemelryk added a comment - Thanks guys, this has been integrated now. Good spotting Mark!
          Hide
          Petr Skoda added a comment -

          Thanks everybody, this is now part of the weekly build.

          Show
          Petr Skoda added a comment - Thanks everybody, this is now part of the weekly build.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: