Details

    • Type: Sub-task
    • Status: Reopened
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 2.1, 2.2.2, 2.7
    • Fix Version/s: BACKEND
    • Component/s: Libraries
    • Labels:
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_27_STABLE

      Description

      These fields are pretty easy to convert during an upgrade.

      1) Create a new user custom field. If it's not possible to replicate the full functionality using a text field type (eg note that Skype can show an online/offline icon) then you will have to create a special new user profile field type as a new plugin.
      2) Copy existing data into this new field.
      3) Drop old column from the user table.
      4) Make sure that all code no longer relies on this field.
      5) Make sure that all code that provides user data (eg web services) behaves as expected and APIs are not changed.

      Fields include:

      • Web URL
      • ICQ
      • Skype
      • AIM
      • Yahoo
      • MSN

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            quen Sam Marshall added a comment -

            Suggestion: For fields which are not very popular and might be dropped from a fresh install, the upgrade process should not migrate these fields unless there is at least one user entry that actually has them set.

            Note: I suspect this change might require alterations to backup/restore, which isn't noted in the description.

            Show
            quen Sam Marshall added a comment - Suggestion: For fields which are not very popular and might be dropped from a fresh install, the upgrade process should not migrate these fields unless there is at least one user entry that actually has them set. Note: I suspect this change might require alterations to backup/restore, which isn't noted in the description.
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Translation is also a consideration – at present, the existing user fields are translatable, but by moving these to custom profile fields, they would cease to be translatable.

            Show
            dobedobedoh Andrew Nicols added a comment - Translation is also a consideration – at present, the existing user fields are translatable, but by moving these to custom profile fields, they would cease to be translatable.
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Another thing to note with this is that the existing fields have certain additional options:

            • hidden unless moodle/usre:viewhiddendetails is set
            • as a URL

            The hidden details may require a change to customfields to allow testing against a specific capability rather than the default options of:

            • Not Visible
            • Visible to User
            • Visible to everyone

            The latter should be relatively easy to sort using the 'link' and 'link target' options.

            Show
            dobedobedoh Andrew Nicols added a comment - Another thing to note with this is that the existing fields have certain additional options: hidden unless moodle/usre:viewhiddendetails is set as a URL The hidden details may require a change to customfields to allow testing against a specific capability rather than the default options of: Not Visible Visible to User Visible to everyone The latter should be relatively easy to sort using the 'link' and 'link target' options.
            Hide
            aborrow Anthony Borrow added a comment -

            Andrew - I've linked this as being a duplicate of MDL-19043 and perhaps the issue of translation might better be handled if the fields were related to message providers. I am not sure that treating them as custom user profile fields is the best way to go. I've not thought it completely through but it seems that messaging/networking is more related to messaging than the custom user profile fields. I would like to see custom profile fields truly be user custom profile fields so that we do not obscure the meaning of those fields. Peace - Anthony

            Show
            aborrow Anthony Borrow added a comment - Andrew - I've linked this as being a duplicate of MDL-19043 and perhaps the issue of translation might better be handled if the fields were related to message providers. I am not sure that treating them as custom user profile fields is the best way to go. I've not thought it completely through but it seems that messaging/networking is more related to messaging than the custom user profile fields. I would like to see custom profile fields truly be user custom profile fields so that we do not obscure the meaning of those fields. Peace - Anthony
            Hide
            dobedobedoh Andrew Nicols added a comment -

            In which case Anthony, I shall pass the gauntlet back to moodle.com until a better plan is formulated!

            Cheers,

            Andrew

            Show
            dobedobedoh Andrew Nicols added a comment - In which case Anthony, I shall pass the gauntlet back to moodle.com until a better plan is formulated! Cheers, Andrew
            Hide
            poltawski Dan Poltawski added a comment -

            [we discussed this at EU meeting]

            The problem is that most of the fields aren't used for messaging, so at the moment putting them into message providers isn't really useful

            Show
            poltawski Dan Poltawski added a comment - [we discussed this at EU meeting] The problem is that most of the fields aren't used for messaging, so at the moment putting them into message providers isn't really useful
            Hide
            mudrd8mz David Mudrak added a comment -

            There is an issue with having the field titles, descriptions a helps localized. Currently the texts are defined as core strings. Once we convert them to custom fields, we need to find a way how to have the titles localized, too. We have the same issue with role names, for example. We can use multilang filter but for multilang sites like moodle.org (with many langs installed), the string is then very very long (hardly to even fit to the DB column).

            Show
            mudrd8mz David Mudrak added a comment - There is an issue with having the field titles, descriptions a helps localized. Currently the texts are defined as core strings. Once we convert them to custom fields, we need to find a way how to have the titles localized, too. We have the same issue with role names, for example. We can use multilang filter but for multilang sites like moodle.org (with many langs installed), the string is then very very long (hardly to even fit to the DB column).
            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for reporting this issue.

            We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

            If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

            Michael d.

            TW9vZGxlDQo=

            Show
            salvetore Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
            Hide
            salvetore Michael de Raadt added a comment -

            I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

            This is being done as part of a bulk annual clean-up of issues.

            If you still believe this is an issue in supported versions, please create a new issue.

            Show
            salvetore Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.
            Hide
            marina Marina Glancy added a comment -

            Reopening the issue, because it is still relevant. And the more time passes since original Moodle development, the less sense the fields like "AIM", "ICQ" or "MSN" make. At the same time the existing list is not enough, moodle.org had to add "Twitter" and "Google+" to this list.

            Show
            marina Marina Glancy added a comment - Reopening the issue, because it is still relevant. And the more time passes since original Moodle development, the less sense the fields like "AIM", "ICQ" or "MSN" make. At the same time the existing list is not enough, moodle.org had to add "Twitter" and "Google+" to this list.

              People

              • Votes:
                7 Vote for this issue
                Watchers:
                11 Start watching this issue

                Dates

                • Created:
                  Updated: