Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-27790 Temporary course remains after restore
  3. MDL-28453

temporary courses which are 'restoration in progress' shouldn't be visible at all.

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.0.4, 2.1.1
    • Component/s: Backup
    • Labels:
      None
    • Testing Instructions:
      Hide

      1) restore a course to a halfway stage and cancel
      2) there should be no temporary courses visible to guests.

      Show
      1) restore a course to a halfway stage and cancel 2) there should be no temporary courses visible to guests.
    • Workaround:
      Hide

      (1) go to the course setting, hide the course.
      or better
      (1) create a category for restored courses. hide this category. only restore courses into this category. (you can move the course after)

      Show
      (1) go to the course setting, hide the course. or better (1) create a category for restored courses. hide this category. only restore courses into this category. (you can move the course after)
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
      git@github.com:nebgor/moodle.git
    • Pull Master Branch:

      Description

      This is a follow up on the parent issue.
      The fix, as a quick response temporary measure to clean up the cosmetics, is to make the course hidden.
      This in no means deals with the issue of the existence of a skeleton course. living skeletons are a no-no. The parent bug should deal with this.

        Gliffy Diagrams

          Activity

          Hide
          nebgor Aparup Banerjee added a comment -

          one liner for 2.x branches to set temporary restoration courses to hidden (cosmetic fix until parent bug is resolved)

          Show
          nebgor Aparup Banerjee added a comment - one liner for 2.x branches to set temporary restoration courses to hidden (cosmetic fix until parent bug is resolved)
          Hide
          nebgor Aparup Banerjee added a comment -

          up for integration (simple one liner)

          Show
          nebgor Aparup Banerjee added a comment - up for integration (simple one liner)
          Hide
          skodak Petr Skoda added a comment -

          I agree this is a good temporary workaround, better to have course hidden then letting in students accidentally.

          The only small problem could if user restoring the course does not have capability to view/enter hidden courses (moodle/course:viewhiddencourses), but the teacher and editing teacher have it by default, so it should not be a big deal...

          Integrated, thanks.

          Show
          skodak Petr Skoda added a comment - I agree this is a good temporary workaround, better to have course hidden then letting in students accidentally. The only small problem could if user restoring the course does not have capability to view/enter hidden courses (moodle/course:viewhiddencourses), but the teacher and editing teacher have it by default, so it should not be a big deal... Integrated, thanks.
          Hide
          dongsheng Dongsheng Cai added a comment -

          Thanks.

          Show
          dongsheng Dongsheng Cai added a comment - Thanks.
          Hide
          skodak Petr Skoda added a comment -

          Thanks everybody, this is now part of the weekly build.

          Show
          skodak Petr Skoda added a comment - Thanks everybody, this is now part of the weekly build.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                1/Aug/11