Moodle
  1. Moodle
  2. MDL-28454

Drag Drop features does not work in IE9 (backport yui 2.9.0+3.4.1 from master)

    Details

    • Database:
      Any
    • Testing Instructions:
      Hide

      1/ try as much JS/YUI interfaces as possible using all supported browsers and OS
      2/ do not ask for better testing instructions

      Show
      1/ try as much JS/YUI interfaces as possible using all supported browsers and OS 2/ do not ask for better testing instructions
    • Workaround:
      Hide

      replacing YUI will be as following (this walkthrough works with Moodle 2.x):

      1) download YUI2 from here: http://yuilibrary.com/downloads/#yui2

      2) create a new folder named: 2.9.0 (or what ever version is the latest YUI 2 has now) in the directory: /lib/yui/

      3) open lib/setup.php and change this line: $CFG->yui2version = '2.8.2'; to the version number you've just downloaded

      4) open /lib/yui/phploader/lib/meta and make a copy of the file config_2.8.2.php and rename the copy to config_###.php where ### is the current version number of YUI 2 you've just downloaded.

      Show
      replacing YUI will be as following (this walkthrough works with Moodle 2.x): 1) download YUI2 from here: http://yuilibrary.com/downloads/#yui2 2) create a new folder named: 2.9.0 (or what ever version is the latest YUI 2 has now) in the directory: /lib/yui/ 3) open lib/setup.php and change this line: $CFG->yui2version = '2.8.2'; to the version number you've just downloaded 4) open /lib/yui/phploader/lib/meta and make a copy of the file config_2.8.2.php and rename the copy to config_###.php where ### is the current version number of YUI 2 you've just downloaded.
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Rank:
      18104

      Description

      drag and drop features does not work in I.E. 9, that this is due to YUI library packaged with Moodle 1.9 and 2.x , the library must be replaced in order to solve this issue.
      you will face this issue in many contexts (such as the drag and drop question type).

      please look at the attached walkthrough to solve this issue.

        Issue Links

          Activity

          Hide
          Petr Škoda added a comment - - edited

          Hello,
          it is a bit more complex task - the phploader has to be upgraded at the same time, all our YUI code has to be tested in all supported browsers. Ideally YUI3 should be updated too, but for some unknown reason it is not compatible with our code.

          YUI in the 1.9.x branch will not be updated because our code is not compatible with newer YUI versions, sorry.

          Petr

          Show
          Petr Škoda added a comment - - edited Hello, it is a bit more complex task - the phploader has to be upgraded at the same time, all our YUI code has to be tested in all supported browsers. Ideally YUI3 should be updated too, but for some unknown reason it is not compatible with our code. YUI in the 1.9.x branch will not be updated because our code is not compatible with newer YUI versions, sorry. Petr
          Hide
          Murad Jamal added a comment -

          Petr, see the walkthrough section here, I tested it and it worked with me. that's why I encourage core devs (here: http://moodle.org/mod/forum/discuss.php?d=181845 ) to commit this change to head

          Show
          Murad Jamal added a comment - Petr, see the walkthrough section here, I tested it and it worked with me. that's why I encourage core devs (here: http://moodle.org/mod/forum/discuss.php?d=181845 ) to commit this change to head
          Hide
          Petr Škoda added a comment -

          Murad,
          today I was told we are very close to the Moodle 2.1.1 release. Changes like this have to be tested a bit more because there is a risk of regressions. We should be importing new TinyMCE with some IE fixes soon too. I hope somebody will resolve issues with latest YUI3 too...

          Show
          Petr Škoda added a comment - Murad, today I was told we are very close to the Moodle 2.1.1 release. Changes like this have to be tested a bit more because there is a risk of regressions. We should be importing new TinyMCE with some IE fixes soon too. I hope somebody will resolve issues with latest YUI3 too...
          Hide
          Murad Jamal added a comment -

          Petr, I appreciate your efforts ... but anyway, aside from that, YUI2 & YUI3 I really find it confusing, why not to use one library: the latest one YUI3? and drop YUI2 forever ...

          Show
          Murad Jamal added a comment - Petr, I appreciate your efforts ... but anyway, aside from that, YUI2 & YUI3 I really find it confusing, why not to use one library: the latest one YUI3? and drop YUI2 forever ...
          Hide
          Petr Škoda added a comment -

          Yeah, that would be great! That is why we are waiting for YUI 3.4.0 - it should finally include all the missing bits that were not yet implemented in YUI3 (such as the treeview widget). Hopefully there will be no traces of YUI2 in Moodle 2.2 that will be hopefully released in December. This should help with performance too.

          Show
          Petr Škoda added a comment - Yeah, that would be great! That is why we are waiting for YUI 3.4.0 - it should finally include all the missing bits that were not yet implemented in YUI3 (such as the treeview widget). Hopefully there will be no traces of YUI2 in Moodle 2.2 that will be hopefully released in December. This should help with performance too.
          Hide
          Petr Škoda added a comment -

          I have just submitted an integration request for YUI 3.4.0 and 2.9.0 for master, hopefully if people test it next week we could backport it to stable.

          Show
          Petr Škoda added a comment - I have just submitted an integration request for YUI 3.4.0 and 2.9.0 for master, hopefully if people test it next week we could backport it to stable.
          Hide
          Petr Škoda added a comment -

          We should probably ask contrib devs to test with this new YUI on moodle.org forums...

          Show
          Petr Škoda added a comment - We should probably ask contrib devs to test with this new YUI on moodle.org forums...
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          One tiny detail I've noticed:

          • In master, using standard theme, the custom-menu shows one gray background when the mouse is over the menu items.
          • In 21_STABLE, backported by this issue, I get one blue2gray-gradient background instead.

          Does not seem important but it's sort of unexpected difference IMO.

          FYI, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - One tiny detail I've noticed: In master, using standard theme, the custom-menu shows one gray background when the mouse is over the menu items. In 21_STABLE, backported by this issue, I get one blue2gray-gradient background instead. Does not seem important but it's sort of unexpected difference IMO. FYI, ciao
          Hide
          Sam Hemelryk added a comment -

          Things appear to be be working perfectly. Thanks Petr.

          Show
          Sam Hemelryk added a comment - Things appear to be be working perfectly. Thanks Petr.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for all the hard work. This is now part of Moodle, your favorite LMS.

          Closing as fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for all the hard work. This is now part of Moodle, your favorite LMS. Closing as fixed, ciao
          Hide
          Martin Dougiamas added a comment -

          Can someone here confirm to me that this will not cause any compatibility issues for third-party modules using YUI2 or YUI3 in 2.1.x ?

          Show
          Martin Dougiamas added a comment - Can someone here confirm to me that this will not cause any compatibility issues for third-party modules using YUI2 or YUI3 in 2.1.x ?

            People

            • Votes:
              27 Vote for this issue
              Watchers:
              15 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: