Moodle
  1. Moodle
  2. MDL-28455

Upgrade TinyMCE to the latest version (3.4.5)

    Details

    • Rank:
      18106

      Description

      at the same time we should probably cleanup the commit messages by rebasing into new branch (adding some unique identifier of our changes into commit messages), add MDL-25490

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          We just did that. Or is there a newer version?

          Show
          Michael de Raadt added a comment - We just did that. Or is there a newer version?
          Hide
          Michael de Raadt added a comment -

          I see there is a new version of TinyMCE with various issues resolved.

          Show
          Michael de Raadt added a comment - I see there is a new version of TinyMCE with various issues resolved.
          Hide
          Ryan Smith added a comment -

          TinyMCE 3.4.4 just came out. Some really good fixes:

          http://www.tinymce.com/develop/changelog/index.php?type=tinymce

          It looks like Moodle is 4 versions behind now.

          Show
          Ryan Smith added a comment - TinyMCE 3.4.4 just came out. Some really good fixes: http://www.tinymce.com/develop/changelog/index.php?type=tinymce It looks like Moodle is 4 versions behind now.
          Hide
          Ryan Smith added a comment -

          TinyMCE 3.4.5 is now out. Released on September 06.

          http://www.tinymce.com/develop/changelog/index.php?type=tinymce

          Looks like lots of IE fixes.

          Show
          Ryan Smith added a comment - TinyMCE 3.4.5 is now out. Released on September 06. http://www.tinymce.com/develop/changelog/index.php?type=tinymce Looks like lots of IE fixes.
          Hide
          Petr Škoda added a comment -

          I am testing a patch right now...

          Show
          Petr Škoda added a comment - I am testing a patch right now...
          Hide
          Sam Hemelryk added a comment -

          On second thoughts I may leave this for Eloy as he reviewed the last upgrade and will likely know what to look for!

          Show
          Sam Hemelryk added a comment - On second thoughts I may leave this for Eloy as he reviewed the last upgrade and will likely know what to look for!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Petr,

          • have been lang packs generated / sent to AMOS?
          • lib/editor/tinymce/version.php needs update?
          Show
          Eloy Lafuente (stronk7) added a comment - Petr, have been lang packs generated / sent to AMOS? lib/editor/tinymce/version.php needs update?
          Hide
          Petr Škoda added a comment -

          1/ the en lang pack did not change, the updates of other langs are independent
          2/ the editor change is not necessary, but I agree we should do it (working on that)

          Show
          Petr Škoda added a comment - 1/ the en lang pack did not change, the updates of other langs are independent 2/ the editor change is not necessary, but I agree we should do it (working on that)
          Hide
          Petr Škoda added a comment - - edited

          I suppose we should get this into master asap because we need more testing by devs before we backport it to 2.1.x, maybe we should split the issue for stable and dev.

          Show
          Petr Škoda added a comment - - edited I suppose we should get this into master asap because we need more testing by devs before we backport it to 2.1.x, maybe we should split the issue for stable and dev.
          Hide
          Petr Škoda added a comment -

          version.php files updated

          Show
          Petr Škoda added a comment - version.php files updated
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Oki, re-aiming this for master only. I've created MDL-29361 about to backport this once tested and working ok to 21_STABLE.

          About the other langs... not sure but it sounds to me that, in previous updates, always David has published "something" in AMOS site (something generated by following the build readme instructions. That's the cause I was asking).

          Show
          Eloy Lafuente (stronk7) added a comment - Oki, re-aiming this for master only. I've created MDL-29361 about to backport this once tested and working ok to 21_STABLE. About the other langs... not sure but it sounds to me that, in previous updates, always David has published "something" in AMOS site (something generated by following the build readme instructions. That's the cause I was asking).
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (master only, see MDL-29361 for backporting). Thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (master only, see MDL-29361 for backporting). Thanks!
          Hide
          Sam Hemelryk added a comment -

          Passing this, things seem fine thanks guys.

          Just as an interesting observation key repetition doesn't work in the editor (holding down a letter and having it repeat).

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Passing this, things seem fine thanks guys. Just as an interesting observation key repetition doesn't work in the editor (holding down a letter and having it repeat). Cheers Sam
          Hide
          Eloy Lafuente (stronk7) added a comment -

          YTC !

          (aka, yay, thanks and ciao ) Closing.

          Show
          Eloy Lafuente (stronk7) added a comment - YTC ! (aka, yay, thanks and ciao ) Closing.

            People

            • Votes:
              3 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: