Moodle
  1. Moodle
  2. MDL-28460

Add one more option to add the moodlelogo image at the bottom of each moodle page using formal_white

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      on the basis of $PAGE->theme->settings->creditstomoodleorg
      you should see at the bottom of moodle pages (using FW theme) the nice moodle logo
      on the basis of the following structure:

      switch ($PAGE->theme->settings->creditstomoodleorg) {
      case 'in every page':
      'nice moodle logo' is present in the front page
      'nice moodle logo' is present in other pages too
      break;
      case 'in the front page only':
      'nice moodle logo' is present in the front page
      'nice moodle logo' is not present in other pages
      break;
      case 'never':
      'nice moodle logo' is not present in the front page
      'nice moodle logo' is not present in other pages
      break;
      default:
      I deplore rude methods
      }

      Show
      on the basis of $PAGE->theme->settings->creditstomoodleorg you should see at the bottom of moodle pages (using FW theme) the nice moodle logo on the basis of the following structure: switch ($PAGE->theme->settings->creditstomoodleorg) { case 'in every page': 'nice moodle logo' is present in the front page 'nice moodle logo' is present in other pages too break; case 'in the front page only': 'nice moodle logo' is present in the front page 'nice moodle logo' is not present in other pages break; case 'never': 'nice moodle logo' is not present in the front page 'nice moodle logo' is not present in other pages break; default: I deplore rude methods }
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-28460_master
    • Rank:
      18121

      Description

      To better resemble formal_white for moodle 1.* it should be nice to add the small moodle logo at the bottom of each page as it was before.

        Issue Links

          Activity

          Hide
          Daniele Cordella added a comment -

          with this push request, I am fixing MDL-28458, MDL-28459 and MDL-28460.
          To see how to test MDL-28458, MDL-28459 see them in detail.

          Show
          Daniele Cordella added a comment - with this push request, I am fixing MDL-28458 , MDL-28459 and MDL-28460 . To see how to test MDL-28458 , MDL-28459 see them in detail.
          Hide
          Michael de Raadt added a comment -

          These changes need to be reviewed before they are sent to integration.

          Show
          Michael de Raadt added a comment - These changes need to be reviewed before they are sent to integration.
          Hide
          Martin Dougiamas added a comment -

          I've just had a look at the code.

          The main thing I would fix is to get rid of the hard-coded styles in layout/general.php and use CSS for that, as per Moodle coding style guide.

          Other than that I think it's OK to go in as it only affects that theme.

          Show
          Martin Dougiamas added a comment - I've just had a look at the code. The main thing I would fix is to get rid of the hard-coded styles in layout/general.php and use CSS for that, as per Moodle coding style guide. Other than that I think it's OK to go in as it only affects that theme.
          Hide
          Daniele Cordella added a comment -

          Martin, the embedded style has been taken from functiom home_link in lib/outputrenders.php

          – Posted from Bugbox for iPhone

          Show
          Daniele Cordella added a comment - Martin, the embedded style has been taken from functiom home_link in lib/outputrenders.php – Posted from Bugbox for iPhone
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The integration of this issue has been delayed to next week due to time constraints. Thanks for your support and patience!

          Sorry and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week due to time constraints. Thanks for your support and patience! Sorry and ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Reopening: missing testing instructions. I love to be rude, lol. :-P

          Show
          Eloy Lafuente (stronk7) added a comment - Reopening: missing testing instructions. I love to be rude, lol. :-P
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Daniele Cordella added a comment -

          Ciao Eloy,
          I am sorry but I am without my computer and quite without web access. Because of this, I can not perform the requested PULL. Although this I don't feel new moodle updates I may affect my "old" pushes. In any case once returned on the web, whether I find my pull still not included, I will perform the PULL you asked. I apologise.

          – Posted from Bugbox for iPhone

          Show
          Daniele Cordella added a comment - Ciao Eloy, I am sorry but I am without my computer and quite without web access. Because of this, I can not perform the requested PULL. Although this I don't feel new moodle updates I may affect my "old" pushes. In any case once returned on the web, whether I find my pull still not included, I will perform the PULL you asked. I apologise. – Posted from Bugbox for iPhone
          Hide
          Sam Hemelryk added a comment -

          Thanks Daniele, this has been integrated now.
          Spot on with this one by the way - I had to fix a conflict because of earlier changes but that is 100% fine!
          Only thing to mention is that again because it is an improvement it has only been integrated to master.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Daniele, this has been integrated now. Spot on with this one by the way - I had to fix a conflict because of earlier changes but that is 100% fine! Only thing to mention is that again because it is an improvement it has only been integrated to master. Cheers Sam
          Hide
          Rossiani Wijaya added a comment -

          Thanks for the improvement Daniele.

          Test passed.

          Show
          Rossiani Wijaya added a comment - Thanks for the improvement Daniele. Test passed.
          Hide
          Daniele Cordella added a comment -

          – Posted from Bugbox for iPhone

          Show
          Daniele Cordella added a comment - – Posted from Bugbox for iPhone
          Hide
          Daniele Cordella added a comment -

          Thanks to you all!

          – Posted from Bugbox for iPhone

          Show
          Daniele Cordella added a comment - Thanks to you all! – Posted from Bugbox for iPhone
          Hide
          Eloy Lafuente (stronk7) added a comment -

          git & cvs repositories have been populated with this solution. Many thanks for your collaboration, yay!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - git & cvs repositories have been populated with this solution. Many thanks for your collaboration, yay! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: